Bugzilla – Attachment 128284 Details for
Bug 15594
Sequence of MARC 260 subfields different on XSLT result list and detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15594: preserve sequence of 260 subfields in detail page
Bug-15594-preserve-sequence-of-260-subfields-in-de.patch (text/plain), 5.79 KB, created by
Blou
on 2021-12-06 18:53:36 UTC
(
hide
)
Description:
Bug 15594: preserve sequence of 260 subfields in detail page
Filename:
MIME Type:
Creator:
Blou
Created:
2021-12-06 18:53:36 UTC
Size:
5.79 KB
patch
obsolete
>From bea2419e4d1b99995d3238702b27001dc3eeb1ca Mon Sep 17 00:00:00 2001 >From: Blou <blou@inlibro.com> >Date: Mon, 6 Dec 2021 13:48:30 -0500 >Subject: [PATCH] Bug 15594: preserve sequence of 260 subfields in detail page > >When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed >$a$a$b$b$c. This goes against the standard. > >This patch preserves the order. > >0) create a notice with $a$b$a subfields. In that (mixed) order. >1) Go to detail page and see the fields displayed as "aab" >2) apply the patch >3) validate the aba display. >--- > .../en/xslt/MARC21slim2OPACDetail.xsl | 44 +++++++++---------- > 1 file changed, 22 insertions(+), 22 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index a7dd374ae5..c6f3b37fb4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -325,53 +325,53 @@ > <xsl:when test="marc:datafield[@tag=260]"> > <span class="results_summary publisher"><span class="label">Publication details: </span> > <xsl:for-each select="marc:datafield[@tag=260]"> >- <span property="publisher" typeof="Organization"> >- <xsl:for-each select="marc:subfield[@code='a']"> >+ <xsl:for-each select="marc:subfield"> >+ <xsl:if test="@code='a'"> >+ <span property="publisher" typeof="Organization"> > <span class="publisher_place" property="location"> > <a> >- <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=pl:"<xsl:value-of select="str:encode-uri(., true())"/>"</xsl:attribute> >- <xsl:value-of select="."/> >+ <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=pl:"<xsl:value-of select="str:encode-uri(current(), true())"/>"</xsl:attribute> >+ <xsl:value-of select="current()"/> > </a> > </span> >+ </span> > <xsl:if test="position() != last()"> > <xsl:text> </xsl:text> > </xsl:if> >- </xsl:for-each> >- <xsl:text> </xsl:text> >- <xsl:if test="marc:subfield[@code='b']"> >+ <xsl:text> </xsl:text> >+ </xsl:if> >+ <xsl:if test="@code='b'"> >+ <span property="publisher" typeof="Organization"> > <span property="name" class="publisher_name"> >- <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Provider:<xsl:value-of select="str:encode-uri(marc:subfield[@code='b'], true())"/></xsl:attribute> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">b</xsl:with-param> >- </xsl:call-template> >+ <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Provider:<xsl:value-of select="str:encode-uri(current(), true())"/></xsl:attribute> >+ <xsl:value-of select="current()"/> > </a> > </span> >+ </span> >+ <xsl:text> </xsl:text> > </xsl:if> >- </span> >- <xsl:text> </xsl:text> >- <xsl:for-each select="marc:subfield[@code='c']"> >+ <xsl:if test="@code='c'"> > <span property="datePublished" class="publisher_date"> > <a> >- <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=copydate:"<xsl:value-of select="str:encode-uri(., true())"/>"</xsl:attribute> >- <xsl:value-of select="."/> >+ <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=copydate:"<xsl:value-of select="str:encode-uri(current(), true())"/>"</xsl:attribute> >+ <xsl:value-of select="current()"/> > </a> > <xsl:if test="position() != last()"> > <xsl:text> </xsl:text> > </xsl:if> > </span> >- </xsl:for-each> >- <xsl:text> </xsl:text> >- <xsl:if test="marc:subfield[@code='g']"> >+ <xsl:text> </xsl:text> >+ </xsl:if> >+ <xsl:if test="@code='g'"> > <span property="datePublished" class="publisher_date"> > <xsl:call-template name="chopPunctuation"> > <xsl:with-param name="chopString"> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">g</xsl:with-param> >- </xsl:call-template> >+ <xsl:value-of select="current()"/> > </xsl:with-param> > </xsl:call-template> > </span> > </xsl:if> >+ </xsl:for-each> > <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose> > </xsl:for-each> > </span> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15594
:
128284
|
128369
|
130194
|
130195
|
131363
|
131382
|
131383
|
131384
|
131385