Attachment 128336 Details for Bug 29043 – Bug 29043: Remaining bug is the incorrect title "Place a hold on No title"

[patch] Bug 29043: Remaining bug is the incorrect title "Place a hold on No title"

Bug-29043-Remaining-bug-is-the-incorrect-title-Pla.patch (text/plain), 1.46 KB, created by Samu Heiskanen on 2021-12-08 01:06:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Samu Heiskanen

Created: 2021-12-08 01:06:18 UTC

Size: 1.46 KB

patch

obsolete

>From a196d7d94f373ac4f4f389b78de361f5fb821b5e Mon Sep 17 00:00:00 2001
>From: Samu Heiskanen <samu.heiskanen@hypernova.fi>
>Date: Wed, 8 Dec 2021 01:03:47 +0000
>Subject: [PATCH] Bug 29043: Remaining bug is the incorrect title "Place a hold
> on No title"
>
>This version takes account of the batch-mode.
>
>I only just add the line:
>
>$template->param( biblio => $biblio ) if scalar @biblionumbers == 1;
>
>inside the foreach loop. All my other patch-fixes are obsolete.
>---
> reserve/request.pl | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 72a43b1098..6df3cb368b 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -326,6 +326,8 @@ foreach my $biblionumber (@biblionumbers) {
>         $template->param('nobiblio' => 1);
>         last;
>     }
>+    
>+    $template->param( biblio => $biblio ) if scalar @biblionumbers == 1;
> 
>     my $count = Koha::Holds->search( { biblionumber => $biblionumber } )->count();
> 
>@@ -735,8 +737,6 @@ foreach my $biblionumber (@biblionumbers) {
>     push @biblioloop, \%biblioloopiter;
> }
> 
>-my $biblio = Koha::Biblios->find( $biblionumber );
>-
> # display infos
> $template->param(
>     reserveloop        => 1,
>@@ -745,7 +745,6 @@ $template->param(
>     date               => $date,
>     biblionumber       => $biblionumber,
>     findborrower       => $findborrower,
>-    biblio             => $biblio,
>     holdsview          => 1,
>     C4::Search::enabled_staff_search_views,
> );
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29043: 124941 | 125060 | 127731 | 127732 | 128254 | 128309 | 128336 | 128337 | 128338 | 128339 | 128340 | 128421 | 128422 | 128423 | 128474 | 128475 | 128476 | 128971 | 128972 | 128973 | 129200 | 129498 | 129530 | 129531 | 129820 | 129821 | 129915 | 129916 | 129949 | 129950