Bugzilla – Attachment 12837 Details for
Bug 8213
"Cancel All" button on holds over tab cancels both holds over and holds waiting
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed off] Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting
Bug-8213---Cancel-All-button-on-holds-over-tab-can.patch (text/plain), 1.56 KB, created by
Melia Meggs
on 2012-10-15 23:17:46 UTC
(
hide
)
Description:
[Signed off] Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting
Filename:
MIME Type:
Creator:
Melia Meggs
Created:
2012-10-15 23:17:46 UTC
Size:
1.56 KB
patch
obsolete
>From 58795fd3e8021bbdff5385736251a14e023b7aeb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 1 Oct 2012 13:36:48 -0400 >Subject: [PATCH] Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting > >Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> >--- > circ/waitingreserves.pl | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl >index c9c9f0e..ec3feb5 100755 >--- a/circ/waitingreserves.pl >+++ b/circ/waitingreserves.pl >@@ -96,12 +96,6 @@ foreach my $num (@getreserves) { > my $holdingbranch = $gettitle->{'holdingbranch'}; > my $homebranch = $gettitle->{'homebranch'}; > >- if ($cancelall) { >- my $res = cancel( $itemnumber, $borrowernum, $holdingbranch, $homebranch, !$transfer_when_cancel_all ); >- push @cancel_result, $res if $res; >- next; >- } >- > my %getreserv = ( > itemnumber => $itemnumber, > borrowernum => $borrowernum, >@@ -139,8 +133,14 @@ foreach my $num (@getreserves) { > } > > if ($today > $calcDate) { >- push @overloop, \%getreserv; >- $overcount++; >+ if ($cancelall) { >+ my $res = cancel( $itemnumber, $borrowernum, $holdingbranch, $homebranch, !$transfer_when_cancel_all ); >+ push @cancel_result, $res if $res; >+ next; >+ } else { >+ push @overloop, \%getreserv; >+ $overcount++; >+ } > }else{ > push @reservloop, \%getreserv; > $reservcount++; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8213
:
12623
|
12837
|
12875