Bugzilla – Attachment 128381 Details for
Bug 28377
Use the API to suspend/resume holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28377: (QA follow-up) Fallback error handling
Bug-28377-QA-follow-up-Fallback-error-handling.patch (text/plain), 1.98 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-12-09 19:40:32 UTC
(
hide
)
Description:
Bug 28377: (QA follow-up) Fallback error handling
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-12-09 19:40:32 UTC
Size:
1.98 KB
patch
obsolete
>From 9f5e251c84fa49dd35e278c32e0d0c1733443857 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 9 Dec 2021 16:32:50 -0300 >Subject: [PATCH] Bug 28377: (QA follow-up) Fallback error handling > >The code only dealt with 404, this patch makes it have a fallback >message for failure codes. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index d957c46af1..110d142fc9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -328,8 +328,11 @@ $(document).ready(function() { > }).error(function (jqXHR, textStatus, errorThrown) { > if (jqXHR.status === 404) { > alert(__("Unable to resume, hold not found")); >- holdsTable.api().ajax.reload(); > } >+ else { >+ alert(_("Your request could not be processed. Check the logs")); >+ } >+ holdsTable.api().ajax.reload(); > }); > }); > >@@ -413,9 +416,12 @@ $(document).ready(function() { > holdsTable.api().ajax.reload(); > }).error(function (jqXHR, textStatus, errorThrown) { > if (jqXHR.status === 404) { >- alert(__("Unable to resume, hold not found")); >- holdsTable.api().ajax.reload(); >+ alert(__("Unable to suspend, hold not found")); > } >+ else { >+ alert(_("Your request could not be processed. Check the logs")); >+ } >+ holdsTable.api().ajax.reload(); > }).done(function() { > $("#suspend-modal-until").val(""); // clean the input > $('#suspend-modal').modal('hide'); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28377
:
121129
|
121130
|
125052
|
125053
|
125057
|
125058
|
127270
|
127271
|
128380
|
128381
|
128402
|
128403
|
128404
|
128405
|
128458
|
128461