Attachment 128412 Details for Bug 28855 – Bug 28855: (follow-up) adapt specific test

[patch] Bug 28855: (follow-up) adapt specific test

Bug-28855-follow-up-adapt-specific-test.patch (text/plain), 1.96 KB, created by David Nind on 2021-12-11 17:37:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-12-11 17:37:13 UTC

Size: 1.96 KB

patch

obsolete

>From 3c3debbcdf7db84acfc9b604c7416c901c10df9d Mon Sep 17 00:00:00 2001
>From: Marion Durand <marion.durand@biblibre.com>
>Date: Tue, 9 Nov 2021 13:08:58 +0000
>Subject: [PATCH] Bug 28855: (follow-up) adapt specific test
>
>Adapt the test of function DelSuggestionsOlderThan to match the new behaviour of the function.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/Suggestions.t | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t
>index 44e90a945a..9093cfc57d 100755
>--- a/t/db_dependent/Suggestions.t
>+++ b/t/db_dependent/Suggestions.t
>@@ -485,10 +485,10 @@ subtest 'DelSuggestionsOlderThan' => sub {
>     # Add four suggestions; note that STATUS needs uppercase (FIXME)
>     my $d1 = output_pref({ dt => dt_from_string->add(days => -2), dateformat => 'sql' });
>     my $d2 = output_pref({ dt => dt_from_string->add(days => -4), dateformat => 'sql' });
>-    my $sugg01 = $builder->build({ source => 'Suggestion', value => { date => $d1, STATUS => 'ASKED' }});
>-    my $sugg02 = $builder->build({ source => 'Suggestion', value => { date => $d1, STATUS => 'CHECKED' }});
>-    my $sugg03 = $builder->build({ source => 'Suggestion', value => { date => $d2, STATUS => 'ASKED' }});
>-    my $sugg04 = $builder->build({ source => 'Suggestion', value => { date => $d2, STATUS => 'ACCEPTED' }});
>+    my $sugg01 = $builder->build({ source => 'Suggestion', value => { manageddate => $d1, date => $d2, STATUS => 'ASKED' }});
>+    my $sugg02 = $builder->build({ source => 'Suggestion', value => { manageddate => $d1, date => $d2, STATUS => 'CHECKED' }});
>+    my $sugg03 = $builder->build({ source => 'Suggestion', value => { manageddate => $d2, date => $d2, STATUS => 'ASKED' }});
>+    my $sugg04 = $builder->build({ source => 'Suggestion', value => { manageddate => $d2, date => $d2, STATUS => 'ACCEPTED' }});
> 
>     # Test no parameter: should do nothing
>     C4::Suggestions::DelSuggestionsOlderThan();
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28855: 127482 | 127483 | 128411 | 128412 | 128464 | 128465