Attachment 128443 Details for Bug 29605 – Bug 29605: search_marc_map.marc_type

[patch] Bug 29605: search_marc_map.marc_type

Bug-29605-searchmarcmapmarctype.patch (text/plain), 1.73 KB, created by Tomás Cohen Arazi (tcohen) on 2021-12-13 11:15:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-12-13 11:15:59 UTC

Size: 1.73 KB

patch

obsolete

>From 94e91bccad4c3d98d23ac6f7b44e205d448bf23d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 2 Dec 2021 12:37:33 +0100
>Subject: [PATCH] Bug 29605: search_marc_map.marc_type
>
>NOT NULL was missing when MODIFY
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/atomicupdate/bug_29605.pl | 3 +++
> installer/data/mysql/db_revs/210600031.pl      | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_29605.pl b/installer/data/mysql/atomicupdate/bug_29605.pl
>index d07fc1f9a3..c1febb4717 100755
>--- a/installer/data/mysql/atomicupdate/bug_29605.pl
>+++ b/installer/data/mysql/atomicupdate/bug_29605.pl
>@@ -59,6 +59,9 @@ return {
>         );
>         say $out "Ensure additional_contents.lang is VARCHAR(50)";
> 
>+        $dbh->do(q{ALTER TABLE search_marc_map MODIFY `marc_type` enum('marc21','unimarc') NOT NULL COMMENT 'what MARC type this map is for'});
>+        say $out "Ensure NOT NULL on search_marc_map.marc_type";
>+
>     },
> 
> }
>diff --git a/installer/data/mysql/db_revs/210600031.pl b/installer/data/mysql/db_revs/210600031.pl
>index 5c92ad7313..c62450925f 100755
>--- a/installer/data/mysql/db_revs/210600031.pl
>+++ b/installer/data/mysql/db_revs/210600031.pl
>@@ -7,6 +7,6 @@ return {
>         my ($args) = @_;
>         my ($dbh, $out) = @$args{qw(dbh out)};
>         $dbh->do(q{DELETE FROM search_marc_map WHERE marc_type='normarc'});
>-        $dbh->do(q{ALTER TABLE search_marc_map MODIFY `marc_type` enum('marc21','unimarc') COMMENT 'what MARC type this map is for'});
>+        $dbh->do(q{ALTER TABLE search_marc_map MODIFY `marc_type` enum('marc21','unimarc') NOT NULL COMMENT 'what MARC type this map is for'});
>     },
> }
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 29605: 128113 | 128114 | 128152 | 128153 | 128154 | 128155 | 128156 | 128157 | 128158 | 128239 | 128313 | 128314 | 128437 | 128438 | 128439 | 128440 | 128441 | 128442 | 128443 | 128444 | 128445 | 128483 | 129153 | 129154 | 129155 | 129156 | 129157 | 129158 | 129159 | 129160 | 129161