Bugzilla – Attachment 128458 Details for
Bug 28377
Use the API to suspend/resume holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28377: (QA follow-up) .js files should use __()
Bug-28377-QA-follow-up-js-files-should-use-.patch (text/plain), 2.25 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-12-13 13:20:08 UTC
(
hide
)
Description:
Bug 28377: (QA follow-up) .js files should use __()
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-12-13 13:20:08 UTC
Size:
2.25 KB
patch
obsolete
>From 02047c3ebfd4624dd19fe05ad0d7a0b5a00761ee Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 13 Dec 2021 10:17:30 -0300 >Subject: [PATCH] Bug 28377: (QA follow-up) .js files should use __() > >As noted by QA, this bug contained uses of _() which is not correct in >include .js files [1]. > >There was another occurence from prior patches (mine :-/) that gets >fixed as well. > >[1] https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 110d142fc9..8276fb5df2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -3,7 +3,7 @@ function display_pickup_location (state) { > if ( state.needs_override === true ) { > $text = $( > '<span>' + state.text + '</span> <span style="float:right;" title="' + >- _("This pickup location is not allowed according to circulation rules") + >+ __("This pickup location is not allowed according to circulation rules") + > '"><i class="fa fa-exclamation-circle" aria-hidden="true"></i></span>' > ); > } >@@ -330,7 +330,7 @@ $(document).ready(function() { > alert(__("Unable to resume, hold not found")); > } > else { >- alert(_("Your request could not be processed. Check the logs")); >+ alert(__("Your request could not be processed. Check the logs")); > } > holdsTable.api().ajax.reload(); > }); >@@ -419,7 +419,7 @@ $(document).ready(function() { > alert(__("Unable to suspend, hold not found")); > } > else { >- alert(_("Your request could not be processed. Check the logs")); >+ alert(__("Your request could not be processed. Check the logs")); > } > holdsTable.api().ajax.reload(); > }).done(function() { >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28377
:
121129
|
121130
|
125052
|
125053
|
125057
|
125058
|
127270
|
127271
|
128380
|
128381
|
128402
|
128403
|
128404
|
128405
|
128458
|
128461