Attachment 128459 Details for Bug 29040 – Bug 29040: Remove warning from the itemtype edit view

[patch] Bug 29040: Remove warning from the itemtype edit view

Bug-29040-Remove-warning-from-the-itemtype-edit-vi.patch (text/plain), 1.68 KB, created by Marcel de Rooy on 2021-12-13 13:20:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-12-13 13:20:51 UTC

Size: 1.68 KB

patch

obsolete

>From 55ec81de96cd04e3b6fb8dde7ac8c157bbd55eec Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 19 Nov 2021 14:54:58 +0100
>Subject: [PATCH] Bug 29040: Remove warning from the itemtype edit view
>Content-Type: text/plain; charset=utf-8
>
>Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121.
>
>We are expecting "intranet" or "opac", here we sent undef which raises a
>warning.
>For no change in behaviour we can send "both" (or whatever different
>than "intranet" and "opac").
>
>Test plan:
>Hit /cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK
>Notice that the warning does no longer appear in the logs with the patch
>applied.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> admin/itemtypes.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl
>index 8652c3de9f..975064af9a 100755
>--- a/admin/itemtypes.pl
>+++ b/admin/itemtypes.pl
>@@ -60,7 +60,7 @@ if ( $op eq 'add_form' ) {
>     my $parent_types = Koha::ItemTypes->search({parent_type=>undef,itemtype => {'!='=>$itemtype_code}});
>     my $imagesets = C4::Koha::getImageSets( checked => ( $itemtype ? $itemtype->imageurl : undef ) );
>     my $searchcategory = GetAuthorisedValues("ITEMTYPECAT");
>-    my $translated_languages = C4::Languages::getTranslatedLanguages( undef , C4::Context->preference('template') );
>+    my $translated_languages = C4::Languages::getTranslatedLanguages( "both", C4::Context->preference('template') );
>     $template->param(
>         itemtype  => $itemtype,
>         parent_type => $parent_type,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29040: 124922 | 124942 | 127866 | 128253 | 128459