Attachment 128461 Details for Bug 28377 – Bug 28377: (QA follow-up) .js files should use __()

[patch] Bug 28377: (QA follow-up) .js files should use __()

Bug-28377-QA-follow-up-js-files-should-use-.patch (text/plain), 1.69 KB, created by Tomás Cohen Arazi (tcohen) on 2021-12-13 13:37:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-12-13 13:37:09 UTC

Size: 1.69 KB

patch

obsolete

>From b350cbd6005b3056565bb94fbd853d9e64decf29 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 13 Dec 2021 10:17:30 -0300
>Subject: [PATCH] Bug 28377: (QA follow-up) .js files should use __()
>
>As noted by QA, this bug contained uses of _() which is not correct in
>include .js files [1].
>
>[1] https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>index 110d142fc9..5570716f52 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>@@ -330,7 +330,7 @@ $(document).ready(function() {
>                             alert(__("Unable to resume, hold not found"));
>                         }
>                         else {
>-                            alert(_("Your request could not be processed. Check the logs"));
>+                            alert(__("Your request could not be processed. Check the logs"));
>                         }
>                         holdsTable.api().ajax.reload();
>                     });
>@@ -419,7 +419,7 @@ $(document).ready(function() {
>                 alert(__("Unable to suspend, hold not found"));
>             }
>             else {
>-                alert(_("Your request could not be processed. Check the logs"));
>+                alert(__("Your request could not be processed. Check the logs"));
>             }
>             holdsTable.api().ajax.reload();
>         }).done(function() {
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 28377: 121129 | 121130 | 125052 | 125053 | 125057 | 125058 | 127270 | 127271 | 128380 | 128381 | 128402 | 128403 | 128404 | 128405 | 128458 | 128461