Bugzilla – Attachment 12847 Details for
Bug 8890
Packages can't be built on master, db dependent test
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN
Bug-8890-KohaBorrowerFiles-shouldnt-use-db-in-BEGI.patch (text/plain), 1.14 KB, created by
Jared Camins-Esakov
on 2012-10-16 09:43:38 UTC
(
hide
)
Description:
Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-10-16 09:43:38 UTC
Size:
1.14 KB
patch
obsolete
>From 7065a6583697ce67804fa7c07a44db1ef1bc71eb Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Tue, 16 Oct 2012 05:41:03 -0400 >Subject: [PATCH] Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN > >This patch removes the usage of the database in Koha::Borrower::Files' >BEGIN block. It also removes the export-related declarations, since >they were unused, and unnecessary in a module called in an object-oriented >fashion. >--- > Koha/Borrower/Files.pm | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/Koha/Borrower/Files.pm b/Koha/Borrower/Files.pm >index 91a5463..d1660bb 100644 >--- a/Koha/Borrower/Files.pm >+++ b/Koha/Borrower/Files.pm >@@ -19,7 +19,7 @@ package Koha::Borrower::Files; > > use Modern::Perl; > >-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); >+use vars qw($VERSION); > > use C4::Context; > use C4::Output; >@@ -30,13 +30,6 @@ BEGIN { > > # set the version for version checking > $VERSION = 0.01; >- require Exporter; >- @ISA = qw(Exporter); >- @EXPORT = qw( >- >- ); >- >- my $debug = C4::Context->preference("DebugLevel"); > } > > =head1 NAME >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8890
:
12739
|
12843
|
12844
|
12846
|
12847
|
12872
|
12873
|
12874
|
13014