Attachment 128540 Details for Bug 29693 – Bug 29693: Make CodeMirror work again

[patch] Bug 29693: Make CodeMirror work again

Bug-29693-Make-CodeMirror-work-again.patch (text/plain), 1.76 KB, created by Jonathan Druart on 2021-12-15 06:22:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-12-15 06:22:36 UTC

Size: 1.76 KB

patch

obsolete

>From a9d57b39bf6e6630907a6fb91e5af34de93198d3 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 14 Dec 2021 15:43:18 +0000
>Subject: [PATCH] Bug 29693: Make CodeMirror work again
>
>To test:
>1. Go to Tools > HTML customizations
>2. Open or create a new entry with CodeMirror. ( Edit with text editor )
>3. CodeMirror doesn't work, you don't see line numbers or syntax highlighting
>4. Apply patch
>5. Try steps 1 & 2 again. The CodeMirror editor should now load.
>6. Make sure it works in both the Default and English(en) tabs.
>7. BONUS: install some other language packs and look at the tabs for that language, it should still work.
>8. Try 5 and 6 again but with Additional contents (News) instead of HTML customizations
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../intranet-tmpl/prog/en/modules/tools/additional-contents.tt  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>index c1a5a01a1c6..1c3ac717cc2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
>@@ -585,7 +585,7 @@
>         [% Asset.js( "lib/linters/htmlhint.min.js" ) | $raw %]
>         [% Asset.js( "lib/codemirror/html-lint.min.js" ) | $raw %]
>         <script>
>-            $("textarea[name='content']").each( function(index) {
>+            $("textarea[name^='content_']").each( function(index) {
>                 var this_lang = $(this).attr('data-lang');
>                 var editor = CodeMirror.fromTextArea(document.getElementById('content_' + this_lang), {
>                     lineNumbers: true,
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29693: 128513 | 128540