Bugzilla – Attachment 128677 Details for
Bug 29680
Reports menu 'Show SQL code' wrong border radius
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29680: Change markup to correct button radius
Bug-29680-Change-markup-to-correct-button-radius.patch (text/plain), 1.58 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-12-17 15:26:33 UTC
(
hide
)
Description:
Bug 29680: Change markup to correct button radius
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-12-17 15:26:33 UTC
Size:
1.58 KB
patch
obsolete
>From 575554b868b2ff90c77f27fd612ee94bb3a7abb1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 13 Dec 2021 14:13:54 +0000 >Subject: [PATCH] Bug 29680: Change markup to correct button radius > >This patch alters the markup around the "Show SQL/Hide SQL" buttons so >that they are not styled as if they are a button group. > >To test, apply the patch and run an SQL report. > >The "Show SQL code" button should be styled consistently with other >single buttons in the toolbar. Click it to test that the "Hide SQL code" >button is also correct. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >index 305de93f34..eaecee422f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >@@ -104,6 +104,8 @@ > </div> > <div class="btn-group"> > <a class="btn btn-default toggle_sql" id="toggle_sql_hid" href="#"><i class="fa fa-eye"></i> Show SQL code</a> >+ </div> >+ <div class="btn-group"> > <a class="btn btn-default toggle_sql" id="toggle_sql_vis" href="#" style="display:none;"><i class="fa fa-eye-slash"></i> Hide SQL code</a> > </div> > <div class="btn-group"> >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29680
:
128466
|
128579
|
128659
| 128677