Bugzilla – Attachment 128681 Details for
Bug 29553
Holds: Can't call method "notforloan" on an undefined value when placing a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29553: Fix crash on undefined notforloan value
Bug-29553-Fix-crash-on-undefined-notforloan-value.patch (text/plain), 1.12 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-12-17 15:54:39 UTC
(
hide
)
Description:
Bug 29553: Fix crash on undefined notforloan value
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-12-17 15:54:39 UTC
Size:
1.12 KB
patch
obsolete
>From d5550f78d22c69e911d452995a635878698af1e3 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 22 Nov 2021 10:53:07 +0000 >Subject: [PATCH] Bug 29553: Fix crash on undefined notforloan value > >Test plan: >Set item level itypes to biblioitems. >Find a record with itemtype NULL, having an item. >Place a hold. Without this patch, it crashes. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: ThibaudGLT <thibaud.guillot@biblibre.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index a42168bc72..706721acab 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1345,7 +1345,7 @@ sub IsAvailableForItemLevelRequest { > # FIXME - a lot of places in the code do this > # or something similar - need to be > # consolidated >- my $itemtype = $item->effective_itemtype; >+ my $itemtype = $item->effective_itemtype or return 0; > my $notforloan_per_itemtype = Koha::ItemTypes->find($itemtype)->notforloan; > > return 0 if >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29553
:
127925
|
128122
| 128681 |
128682
|
128683