Bugzilla – Attachment 128839 Details for
Bug 29747
Cataloguing upload plugin broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29747: Delete columns that don't exist from settings
Bug-29747-Delete-columns-that-dont-exist-from-sett.patch (text/plain), 1.62 KB, created by
Andrew Fuerste-Henry
on 2021-12-21 14:09:26 UTC
(
hide
)
Description:
Bug 29747: Delete columns that don't exist from settings
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2021-12-21 14:09:26 UTC
Size:
1.62 KB
patch
obsolete
>From 67dfd167d595a52e3f8aa8aa77932168dbefd7b7 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 21 Dec 2021 13:20:46 +0000 >Subject: [PATCH] Bug 29747: Delete columns that don't exist from settings > >This patch simply checks if we are callinmg from the plugin, and removes >two columns from the settings if so > >To test: > 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework > 2 - Search for 856$u > 3 - Set Plugin to upload.pl > 4 - Edit a record in the default framework > 5 - Under 856u, click 'Upload' > 6 - Uplaod a file and then click 'Choose' > 7 - nothing happens > 8 - View consiole (f12) and see error > 9 - Apply patch >10 - Reload the page >11 - No more error >12 - Click choose >13 - Record link is populated > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt >index 7a232de0ef..3127015171 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt >@@ -460,6 +460,10 @@ > window.close(); > } > var columns_settings = [% TablesSettings.GetColumns( 'tools', 'upload', 'uploadresults', 'json' ) | $raw %]; >+ [% IF plugin %] >+ delete columns_settings[6]; >+ delete columns_settings[5]; >+ [% END %] > $(document).ready(function() { > KohaTable("uploadresults",{ > }, columns_settings); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29747
:
128833
|
128839
|
128862