Attachment 128861 Details for Bug 29540 – Bug 29540: Raise flagsrequired in modrequest

[patch] Bug 29540: Raise flagsrequired in modrequest

Bug-29540-Raise-flagsrequired-in-modrequest.patch (text/plain), 2.00 KB, created by Marcel de Rooy on 2021-12-22 14:32:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-12-22 14:32:10 UTC

Size: 2.00 KB

patch

obsolete

>From 46cbc39b61333b9d1a58e807e6bda4997eaeaea2 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 22 Nov 2021 07:55:47 +0000
>Subject: [PATCH] Bug 29540: Raise flagsrequired in modrequest
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>Try modrequest with a user having only 'catalogue' perms and the following URLs:
>[1] /cgi-bin/koha/reserve/modrequest.pl?reserve_id=XX&CancelBorrowerNumber=XX&CancelItemnumber=XX&biblionumber=XX
>    Fill the XXs with correct identifiers for some item level hold.
>[2] /cgi-bin/koha/reserve/modrequest_suspendall.pl?suspend=1&suspend_until=2021-12-01&borrowernumber=XX
>    Fill the XX with borrowernumber for borrower that has pending holds.
>You should see: Error: You do not have permission to access this page.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>[AMENDED] More consensus for using reserveforothers than circulate_remaining.
>---
> reserve/modrequest.pl            | 2 +-
> reserve/modrequest_suspendall.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl
>index 3a7c3deb6b..c7f686717f 100755
>--- a/reserve/modrequest.pl
>+++ b/reserve/modrequest.pl
>@@ -36,7 +36,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>         template_name   => "about.tt",
>         query           => $query,
>         type            => "intranet",
>-        flagsrequired   => { catalogue => 1 },
>+        flagsrequired   => { reserveforothers => 1 },
>     }
> );
> 
>diff --git a/reserve/modrequest_suspendall.pl b/reserve/modrequest_suspendall.pl
>index 3217dbffb4..0a802782b5 100755
>--- a/reserve/modrequest_suspendall.pl
>+++ b/reserve/modrequest_suspendall.pl
>@@ -34,7 +34,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>         template_name   => "about.tt",
>         query           => $query,
>         type            => "intranet",
>-        flagsrequired   => { catalogue => 1 },
>+        flagsrequired   => { reserveforothers => 1 },
>     }
> );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29540: 127915 | 128861 | 128952 | 129135