Attachment 128881 Details for Bug 29764 – Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD

[patch] Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD

Bug-29764-Fix-incorrect-EmbedItems-RecordProcessor.patch (text/plain), 1.54 KB, created by Tomás Cohen Arazi (tcohen) on 2021-12-23 11:48:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-12-23 11:48:07 UTC

Size: 1.54 KB

patch

obsolete

>From 5ffb69b03c4d46fe61551184e1dfc7cdd36527d7 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 23 Dec 2021 08:41:33 -0300
>Subject: [PATCH] Bug 29764: Fix incorrect EmbedItems RecordProcessor filter
> POD
>
>This patch makes the usage POD for the EmbedItems filter actually be
>usable. The filter is used in opac-ISBDdetail.pl and the POD is updated
>to how it is used there.
>
>Not much to test.
>---
> Koha/Filter/MARC/EmbedItems.pm | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
>diff --git a/Koha/Filter/MARC/EmbedItems.pm b/Koha/Filter/MARC/EmbedItems.pm
>index ae8ec34a26..2839694ff8 100644
>--- a/Koha/Filter/MARC/EmbedItems.pm
>+++ b/Koha/Filter/MARC/EmbedItems.pm
>@@ -28,21 +28,22 @@ my $biblio = Koha::Biblios->find(
>     { prefetch => [ items, metadata ] }
> );
> 
>-my $rules = C4::Context->yaml_preference('OpacHiddenItems');
>+my $patron = Koha::Patrons->find($loggedinuser);
> 
>-my @items  = grep { !$_->hidden_in_opac({ rules => $rules }) @{$biblio->items};
> my $record = $biblio->metadata->record;
>+my @items  = $biblio->items->filter_by_visible_in_opac({ patron => $patron })->as_list;
> 
>-my $processor = Koha::RecordProcessor->new(
>+my $record_processor = Koha::RecordProcessor->new(
>     {
>-        filters => ('EmbedItems'),
>+        filters => ['EmbedItems'],
>         options => {
>-            items        => \@items
>+            interface => 'opac',
>+            items     => \@items
>         }
>     }
> );
> 
>-$processor->process( $record );
>+$record_processor->process($record);
> 
> =head1 DESCRIPTION
> 
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 29764: 128880 | 128881 | 128983 | 129232