Attachment 128940 Details for Bug 29758 – Bug 29758: Get rid of warning in members/boraccount.pl

[patch] Bug 29758: Get rid of warning in members/boraccount.pl

Bug-29758-Get-rid-of-warning-in-membersboraccountp.patch (text/plain), 1.41 KB, created by David Nind on 2021-12-31 17:00:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-12-31 17:00:56 UTC

Size: 1.41 KB

patch

obsolete

>From 29f63122276475334fa2f6a0c2952c62e6f06309 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 23 Dec 2021 15:51:52 -0300
>Subject: [PATCH] Bug 29758: Get rid of warning in members/boraccount.pl
>
>This patch removes a noisy warning found in production logs.
>
>To test:
>1. Run:
>   $ tail -f /var/log/koha/kohadev/plack-intranet-error.log
>2. Open the 'Accounting' tab for a patron, then click on 'Transactions'
>=> FAIL: You see this kind of warning in the logs:
>
>[WARN] CGI::param called in list context from...
>3. Apply this patch
>4. Repeat 2 (change tab and go back)
>=> SUCCESS: No more warning!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> members/boraccount.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/boraccount.pl b/members/boraccount.pl
>index b28e665904..303fdb9c18 100755
>--- a/members/boraccount.pl
>+++ b/members/boraccount.pl
>@@ -54,7 +54,7 @@ my $borrowernumber = $input->param('borrowernumber');
> my $payment_id     = $input->param('payment_id');
> my $change_given   = $input->param('change_given');
> my $action         = $input->param('action') || '';
>-my @renew_results  = $input->param('renew_result');
>+my @renew_results  = $input->multi_param('renew_result');
> 
> my $logged_in_user = Koha::Patrons->find( $loggedinuser );
> my $library_id = C4::Context->userenv->{'branch'};
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29758: 128907 | 128940 | 129192