Attachment 128992 Details for Bug 29790 – Bug 29790: Restore warning if deletion of serial item fails

[patch] Bug 29790: Restore warning if deletion of serial item fails

Bug-29790-Restore-warning-if-deletion-of-serial-it.patch (text/plain), 1.56 KB, created by Jonathan Druart on 2022-01-04 15:12:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-04 15:12:29 UTC

Size: 1.56 KB

patch

obsolete

>From 330c882392df7928c39fba6115fed48ebfc3fdc4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 4 Jan 2022 15:59:15 +0100
>Subject: [PATCH] Bug 29790: Restore warning if deletion of serial item fails
>
>If the deletion of a serial item failed, the UI did not provide a warning/error message.
>
>Test plan:
>0. Create a new subscription with "Create an item record when receiving
>this serial"
>1. Receive a new item, set a barcode
>2. Check it out
>3. Select the item you have received in the serial item list (page
>"Serial collection information") and click "Delete selected issues"
>4. Tick "Delete the associated items" and confirm the deletion
>=> Without this patch the deletion fail but the UI does not warn it
>=> With this patch applied you see a warning "one or more associated
>items could not be deleted at this time."
>---
> serials/serials-collection.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl
>index 963eeeb577e..2179b830699 100755
>--- a/serials/serials-collection.pl
>+++ b/serials/serials-collection.pl
>@@ -123,9 +123,9 @@ if($op eq 'delete_confirm'){
>         }
>         my $items = Koha::Items->search({ itemnumber => \@itemnumbers });
>         while ( my $item = $items->next ) {
>-            my $error = $item->safe_delete;
>+            my $deleted = $item->safe_delete;
>             $template->param(error_delitem => 1)
>-                if $error eq '1';
>+                unless $deleted;
>         }
>     }
>     for my $serialid (@serialsid){
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29790: 128992 | 129006 | 129168