Bugzilla – Attachment 129016 Details for
Bug 29795
If branch is mandatory on patron self registration form, the pull down should default to empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29795: add empty value for branchcode on self-reg form
Bug-29795-add-empty-value-for-branchcode-on-self-r.patch (text/plain), 2.16 KB, created by
Lucas Gass (lukeg)
on 2022-01-04 22:48:04 UTC
(
hide
)
Description:
Bug 29795: add empty value for branchcode on self-reg form
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-01-04 22:48:04 UTC
Size:
2.16 KB
patch
obsolete
>From 6997250f251dc3f310b4f1604b2039cbcd3ab28e Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 4 Jan 2022 22:44:32 +0000 >Subject: [PATCH] Bug 29795: add empty value for branchcode on self-reg form > >1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField >2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically >3. Fill out the other required fields and the captcha. Don't change the branchcode value. >4. Submit the form, it submits. >5. If branchcode is required it should default to an empty value and force the user to make a choice. >6. Apply patch >7. Repeat 1-3 >8. Now you cannot submit the form unless you choose a branchcode >9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 8d2b8a0f78..cd1142f3bd 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -249,6 +249,9 @@ > <label for="borrower_branchcode" class="[% required.branchcode | html %]">Home library:</label> > > <select id="borrower_branchcode" name="borrower_branchcode" class="[% required.branchcode | html %]"> >+ [% IF required.branchcode %] >+ <option value=""></option> >+ [% END %] > [% FOREACH l IN libraries %] > [% IF l.branchcode == borrower.branchcode %] > <option value="[% l.branchcode | html %]" selected="selected">[% l.branchname | html %]</option> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29795
:
129016
|
130236
|
130542