Bugzilla – Attachment 129049 Details for
Bug 29804
Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding
Bug-29804-Fix-KohaHold-ispickuplocationvalid-explo.patch (text/plain), 2.00 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-01-06 10:19:14 UTC
(
hide
)
Description:
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-01-06 10:19:14 UTC
Size:
2.00 KB
patch
obsolete
>From 22031cf638627b46ead9a5cc3939935803fef559 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 6 Jan 2022 07:13:57 -0300 >Subject: [PATCH] Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding > >This trivial patch acknowledges the fact bug 28871 is probably not going >to be pushed, and changes the method so it, internally, uses >Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in >scalar context. > >This is probably the correct solution as the discussion on bug 28883 >points towards the future removal of the use of wantarray altogether, >eventually. > >To test: >1. Apply the regression tests patch >2. Run: > $ kshell > k$ prove t/db_dependent/Koha/Hold.t >=> FAIL: It explodes as we see in production, with: >The method Koha::Libraries->branchcode is not covered by tests! >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Tests pass! >5. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Hold.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 9736dc527f..5b258aafaa 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -238,16 +238,16 @@ sub is_pickup_location_valid { > Koha::Exceptions::MissingParameter->throw('The library_id parameter is mandatory') > unless $params->{library_id}; > >- my @pickup_locations; >+ my $pickup_locations; > > if ( $self->itemnumber ) { # item-level >- @pickup_locations = $self->item->pickup_locations({ patron => $self->patron }); >+ $pickup_locations = $self->item->pickup_locations({ patron => $self->patron }); > } > else { # biblio-level >- @pickup_locations = $self->biblio->pickup_locations({ patron => $self->patron }); >+ $pickup_locations = $self->biblio->pickup_locations({ patron => $self->patron }); > } > >- return any { $_->branchcode eq $params->{library_id} } @pickup_locations; >+ return any { $_->branchcode eq $params->{library_id} } $pickup_locations->as_list; > } > > =head3 set_pickup_location >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29804
:
129048
|
129049
|
129054
|
129055
|
129078
|
129079