Bugzilla – Attachment 129058 Details for
Bug 29806
->pickup_locations should always be called in scalar context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29806: Call ->as_list for ->pickup_locations on request.pl
Bug-29806-Call--aslist-for--pickuplocations-on-req.patch (text/plain), 936 bytes, created by
Tomás Cohen Arazi (tcohen)
on 2022-01-06 12:32:29 UTC
(
hide
)
Description:
Bug 29806: Call ->as_list for ->pickup_locations on request.pl
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-01-06 12:32:29 UTC
Size:
936 bytes
patch
obsolete
>From 9413dccb53c753e0477a891a9a762f3565508f60 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 6 Jan 2022 09:22:05 -0300 >Subject: [PATCH] Bug 29806: Call ->as_list for ->pickup_locations on > request.pl > >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 1b6638307d..8a552716dc 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -746,7 +746,7 @@ foreach my $biblionumber (@biblionumbers) { > > if ( $patron ) { > # Add the valid pickup locations >- my @pickup_locations = $biblio->pickup_locations({ patron => $patron }); >+ my @pickup_locations = $biblio->pickup_locations({ patron => $patron })->as_list; > $biblioloopiter{pickup_locations} = \@pickup_locations; > $biblioloopiter{pickup_locations_codes} = [ map { $_->branchcode } @pickup_locations ]; > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29806
:
129058
|
129059
|
129060
|
129130
|
129131
|
129132
|
129183
|
129184
|
129185
|
129186