Bugzilla – Attachment 129060 Details for
Bug 29806
->pickup_locations should always be called in scalar context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29806: Fix POST /holds use of pickup_locations
Bug-29806-Fix-POST-holds-use-of-pickuplocations.patch (text/plain), 1.49 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-01-06 12:32:37 UTC
(
hide
)
Description:
Bug 29806: Fix POST /holds use of pickup_locations
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-01-06 12:32:37 UTC
Size:
1.49 KB
patch
obsolete
>From c3484b6433a5ad0a4a1b4e04ce04881415e56e08 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 6 Jan 2022 09:27:45 -0300 >Subject: [PATCH] Bug 29806: Fix POST /holds use of pickup_locations > >This patch makes Koha::Item->pickup_locations and >Koha::Biblio->pickup_locations explicitly call ->as_list in list >context. This way we workaround bug 28871. > >To test: >1. Apply the regression tests patch >2. Run: > $ kshell > k$ prove t/db_dependent/api/v1/holds.t >=> FAIL: Tests fail, the route gives a 500 (unhandled exception) >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Tests pass, the route correctly returns a 400 with a >message about the pickup location being invalid >5. Sign off :-D >--- > Koha/REST/V1/Holds.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm >index 0ca60b1459..92e6e4774e 100644 >--- a/Koha/REST/V1/Holds.pm >+++ b/Koha/REST/V1/Holds.pm >@@ -148,13 +148,13 @@ sub add { > $valid_pickup_location = > any { $_->branchcode eq $pickup_library_id } > $item->pickup_locations( >- { patron => $patron } ); >+ { patron => $patron } )->as_list; > } > else { > $valid_pickup_location = > any { $_->branchcode eq $pickup_library_id } > $biblio->pickup_locations( >- { patron => $patron } ); >+ { patron => $patron } )->as_list; > } > > return $c->render( >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29806
:
129058
|
129059
|
129060
|
129130
|
129131
|
129132
|
129183
|
129184
|
129185
|
129186