Bugzilla – Attachment 129104 Details for
Bug 28909
Allow interlibrary loans illview method to use backend template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28909: (follow-up) Update test for warning and rename variable
Bug-28909-follow-up-Update-test-for-warning-and-re.patch (text/plain), 1.76 KB, created by
Nick Clemens (kidclamp)
on 2022-01-06 16:39:21 UTC
(
hide
)
Description:
Bug 28909: (follow-up) Update test for warning and rename variable
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-01-06 16:39:21 UTC
Size:
1.76 KB
patch
obsolete
>From bde6494160feec8dda33b3d25981f48ba7401b3a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 6 Jan 2022 16:33:14 +0000 >Subject: [PATCH] Bug 28909: (follow-up) Update test for warning and rename > variable > >Variable was updated for params, need to update declaration too > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/StockRotationItems.t | 2 +- > tools/stockrotation.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/StockRotationItems.t b/t/db_dependent/StockRotationItems.t >index 820cc680e1..36c52f1888 100755 >--- a/t/db_dependent/StockRotationItems.t >+++ b/t/db_dependent/StockRotationItems.t >@@ -267,7 +267,7 @@ subtest "Tests for needs_advancing." => sub { > )->store; > is($dbitem->needs_advancing, 1, "Ready to be advanced."); > $dbtransfer->delete; >- warning_is {$dbitem->needs_advancing} "We have no historical branch transfer for itemnumber " . $dbitem->item->itemnumber . "; This should not have happened!", "Missing transfer is warned."; >+ warning_is {$dbitem->needs_advancing} "We have no historical branch transfer for item " . $dbitem->item->itemnumber . "; This should not have happened!", "Missing transfer is warned."; > > $schema->storage->txn_rollback; > }; >diff --git a/tools/stockrotation.pl b/tools/stockrotation.pl >index 4523c99174..04ff184da5 100755 >--- a/tools/stockrotation.pl >+++ b/tools/stockrotation.pl >@@ -252,7 +252,7 @@ if (!defined $op) { > > # Get all items on this rota, for each prefetch their > # stage and biblio objects >- my $items = Koha::StockRotationItems->search( >+ my $sritems = Koha::StockRotationItems->search( > { 'stage.rota_id' => $params{rota_id} }, > { > prefetch => { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28909
:
124174
|
124270
|
124271
|
129102
|
129103
|
129104
|
138856
|
138857
|
138858
|
138922
|
138923