Attachment 129164 Details for Bug 29789 – Bug 29789: Remove unused $error from cataloguing/additem.pl

[patch] Bug 29789: Remove unused $error from cataloguing/additem.pl

Bug-29789-Remove-unused-error-from-cataloguingaddi.patch (text/plain), 1.85 KB, created by Kyle M Hall (khall) on 2022-01-07 13:47:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-01-07 13:47:27 UTC

Size: 1.85 KB

patch

obsolete

>From a7e3e69ab523415d28ca3bb70db7a83d63d879d0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 4 Jan 2022 15:40:19 +0100
>Subject: [PATCH] Bug 29789: Remove unused $error from cataloguing/additem.pl
>
>my $error        = $input->param('error');
>
>It should be removed as $error is used later but not related to this variable.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> cataloguing/additem.pl | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index 80e17abda32..c98eacae848 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -78,7 +78,6 @@ sub get_item_from_cookie {
> }
> 
> my $input        = CGI->new;
>-my $error        = $input->param('error');
> 
> my $biblionumber;
> my $itemnumber;
>@@ -377,7 +376,7 @@ if ($op eq "additem") {
> #-------------------------------------------------------------------------------
>     # check that there is no issue on this item before deletion.
>     my $item = Koha::Items->find($itemnumber);
>-    $error = $item->safe_delete;
>+    my $error = $item->safe_delete;
>     if(ref($error) eq 'Koha::Item'){
>         print $input->redirect("additem.pl?biblionumber=$biblionumber&frameworkcode=$frameworkcode&searchid=$searchid");
>     }else{
>@@ -389,7 +388,7 @@ if ($op eq "additem") {
> #-------------------------------------------------------------------------------
>     my $items = Koha::Items->search({ biblionumber => $biblionumber });
>     while ( my $item = $items->next ) {
>-        $error = $item->safe_delete({ skip_record_index => 1 });
>+        my $error = $item->safe_delete({ skip_record_index => 1 });
>         next if ref $error eq 'Koha::Item'; # Deleted item is returned if deletion successful
>         push @errors,$error;
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29789: 128991 | 129005 | 129164