Bugzilla – Attachment 129189 Details for
Bug 29336
Some authorised_value FKs are too short
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29336: Remove TODOs
Bug-29336-Remove-TODOs.patch (text/plain), 2.99 KB, created by
Jonathan Druart
on 2022-01-07 15:05:49 UTC
(
hide
)
Description:
Bug 29336: Remove TODOs
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-01-07 15:05:49 UTC
Size:
2.99 KB
patch
obsolete
>From 1ea34e9fc152f3374f60d5615f7aed5d667d1a8e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 7 Jan 2022 16:04:28 +0100 >Subject: [PATCH] Bug 29336: Remove TODOs > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > installer/data/mysql/kohastructure.sql | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index c103f71b5ec..e4909b59b7d 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -854,7 +854,7 @@ CREATE TABLE `auth_subfield_structure` ( > `repeatable` tinyint(4) NOT NULL DEFAULT 0, > `mandatory` tinyint(4) NOT NULL DEFAULT 0, > `tab` tinyint(1) DEFAULT NULL, >- `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT '#TODO This is a AV category!', >+ `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `value_builder` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `seealso` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `isurl` tinyint(1) DEFAULT NULL, >@@ -884,7 +884,7 @@ CREATE TABLE `auth_tag_structure` ( > `libopac` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `repeatable` tinyint(4) NOT NULL DEFAULT 0, > `mandatory` tinyint(4) NOT NULL DEFAULT 0, >- `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT '#TODO This is a AV category!', >+ `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > PRIMARY KEY (`authtypecode`,`tagfield`), > CONSTRAINT `auth_tag_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; >@@ -3502,7 +3502,7 @@ CREATE TABLE `marc_subfield_structure` ( > `important` tinyint(4) NOT NULL DEFAULT 0, > `kohafield` varchar(40) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `tab` tinyint(1) DEFAULT NULL, >- `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT '#TODO This is a AV category!', >+ `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `authtypecode` varchar(20) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `value_builder` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `isurl` tinyint(1) DEFAULT NULL, >@@ -3536,7 +3536,7 @@ CREATE TABLE `marc_tag_structure` ( > `repeatable` tinyint(4) NOT NULL DEFAULT 0, > `mandatory` tinyint(4) NOT NULL DEFAULT 0, > `important` tinyint(4) NOT NULL DEFAULT 0, >- `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT '#TODO This is a AV category!', >+ `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `ind1_defaultvalue` varchar(1) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `ind2_defaultvalue` varchar(1) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `frameworkcode` varchar(4) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29336
:
127051
|
127052
|
127053
|
127169
|
127170
|
127171
|
127172
|
128655
|
128656
|
129187
|
129188
| 129189