Bugzilla – Attachment 129202 Details for
Bug 29820
Print summary just show 20 items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29820: Set paging option using boolean instead of string
Bug-29820-Set-paging-option-using-boolean-instead-.patch (text/plain), 2.13 KB, created by
Owen Leonard
on 2022-01-07 19:47:49 UTC
(
hide
)
Description:
Bug 29820: Set paging option using boolean instead of string
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-01-07 19:47:49 UTC
Size:
2.13 KB
patch
obsolete
>From afca8d6eff483ebd139fda1a492905bb7f79e402 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 7 Jan 2022 19:34:21 +0000 >Subject: [PATCH] Bug 29820: Set paging option using boolean instead of string > >Bug 28450, "Make Account summary print tables configurable," added >DataTables to the print summary view. The updated page includes the >wrong option: > >"paging": "false", > >It should be: > >"paging": false, > >Because DataTables expects that option to be boolean (true or false). > >To test, apply the patch and check out to a patron who has more than 20 >checkouts and more than 20 holds. > > - From the toolbar, click Print -> Print summary. > - On the acount summary page, confirm that the "Items checked out" and > "Pending holds" tables show ALL entries, not just the first 20. >--- > .../prog/en/modules/members/moremember-print.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >index 874df51a62..84dfbffd8f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >@@ -225,7 +225,7 @@ > > KohaTable("print-summary-checkouts", { > "dom": "Bt", >- "paging": "false", >+ "paging": false, > initComplete: function( settings) { > moveColumnsButton( settings.nTable.id ); > } >@@ -233,7 +233,7 @@ > > KohaTable("print-summary-holds", { > "dom": "Bt", >- "paging": "false", >+ "paging": false, > initComplete: function( settings) { > moveColumnsButton( settings.nTable.id ); > } >@@ -241,7 +241,7 @@ > > KohaTable("print-summary-fines", { > "dom": "Bt", >- "paging": "false", >+ "paging": false, > initComplete: function( settings) { > moveColumnsButton( settings.nTable.id ); > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29820
:
129190
|
129202
|
129209
|
129220