Bugzilla – Attachment 12921 Details for
Bug 7825
Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7825: Followup prevent submission without choosing an item
Bug-7825-Followup-prevent-submission-without-choos.patch (text/plain), 3.75 KB, created by
Kyle M Hall (khall)
on 2012-10-18 19:54:01 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7825: Followup prevent submission without choosing an item
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-10-18 19:54:01 UTC
Size:
3.75 KB
patch
obsolete
>From afc1799a51268a0dbfd2cd6fe0f9699e4c3b534c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 17 Oct 2012 11:42:53 +0200 >Subject: [PATCH] Bug 7825: Followup prevent submission without choosing an item >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../opac-tmpl/prog/en/modules/opac-reserve.tt | 24 +++++++++++-------- > 1 files changed, 14 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt >index 7b6de14..598a282 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt >@@ -30,7 +30,9 @@ > $(".copiesrow").hide(); > > $("#place_on_hdr").show(); >- $(".place_on_type").show(); >+ [% IF OPACItemHolds == 'yes' %] >+ $(".place_on_type").show(); >+ [% END %] > > // Replace non-JS single-selection with multi-selection capability. > $(".reserve_mode").val("multi"); >@@ -146,7 +148,6 @@ > > $("#selections").val(selections); > $("#biblionumbers").val(biblionumbers); >- > return true; > }); > >@@ -336,7 +337,7 @@ > > [% IF ( bibitemloo.holdable ) %] > <!-- HOLDABLE --> >- [% IF OPACItemHolds == 'yes' %] >+ [% IF OPACItemHolds == 'yes' or OPACItemHolds == 'force' %] > <!-- ITEM HOLDS --> > <td class="place_on_type" style="display:none"> > <ul> >@@ -345,7 +346,7 @@ > id="reqany_[% bibitemloo.biblionumber %]" > class="selectany" > value="Any" >- checked="checked" >+ [% IF OPACItemHolds == "yes" %]checked="checked"[% END %] > /> > <label for="reqany_[% bibitemloo.biblionumber %]">Next available copy</label> > </li> >@@ -354,18 +355,21 @@ > id="reqspecific_[% bibitemloo.biblionumber %]" > class="selectspecific" > value="Specific" >+ [% IF OPACItemHolds == "force" %]checked="checked"[% END %] > /> > <label for="reqspecific_[% bibitemloo.biblionumber %]">A specific copy</label> > </li> > </ul> > </td> >- [% ELSIF OPACItemHolds == 'force' %] >-<script type="text/javascript"> >- $(document).ready(function() { >- $("#copiesrow_[% bibitemloo.biblionumber %]").show(); >- }); >-</script> >+ [% IF OPACItemHolds == 'force' %] >+ <script type="text/javascript"> >+ $(document).ready(function() { >+ $("#copiesrow_[% bibitemloo.biblionumber %]").show(); >+ }); >+ </script> > [% END %] >+ [% END %] >+ > [% END # holdable%] > [% UNLESS ( singleBranchMode ) %] > [% IF ( bibitemloo.holdable ) %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7825
:
8641
|
8645
|
8646
|
12881
|
12883
|
12884
|
12885
|
12915
|
12920
|
12921
|
12922
|
12923
|
13305
|
13306
|
13307
|
13340
|
13341
|
13350
|
15032
|
15033
|
15034
|
15035
|
15606
|
15607
|
18435
|
18436
|
18878
|
18879
|
18903
|
18904
|
18920
|
18924
|
18925
|
18926
|
18927
|
18928
|
22635
|
22877
|
23631
|
24218
|
24270
|
24271
|
24538
|
24539
|
24540
|
24541
|
24542
|
24578
|
24579
|
24591
|
24592
|
27961
|
27962
|
27963
|
27964
|
27965
|
27966