Bugzilla – Attachment 129288 Details for
Bug 29845
Styling OverDrive buttons is difficult
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29845: add IDs to overdrive results action buttons
Bug-29845-add-IDs-to-overdrive-results-action-butt.patch (text/plain), 3.46 KB, created by
Lucas Gass (lukeg)
on 2022-01-10 22:52:05 UTC
(
hide
)
Description:
Bug 29845: add IDs to overdrive results action buttons
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-01-10 22:52:05 UTC
Size:
3.46 KB
patch
obsolete
>From 5e2beb752442e3d10d6b3dd262603077b2c58651 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 10 Jan 2022 22:47:11 +0000 >Subject: [PATCH] Bug 29845: add IDs to overdrive results action buttons > >To test: >1. You must have OverDrive credentials populated in the OverDrive system preferences >2. Go to the Overdrive results page and make sure you are logged in. >3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. >4. Apply patch >5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. >--- > koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js b/koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js >index f71fd13fae..2e73ddd64f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js >@@ -320,7 +320,7 @@ KOHA.OverDriveCirculation = new function() { > if (lockable_formats.length > 0 && checkout_popup) { > $(el).append( ajax_button( __("Download as:"), function() { > checkout_format(el, id, lockable_formats, copies_available); >- }) ).append(" "); >+ }, "downloadas") ).append(" "); > } > } > >@@ -330,7 +330,7 @@ KOHA.OverDriveCirculation = new function() { > if( confirm( __("Are you sure you want to return this item?") ) ) { > item_action({action: "return", id: id}, el, copies_available + 1); > } >- }) ); >+ }, "checkin") ); > > return item; > } >@@ -371,12 +371,12 @@ KOHA.OverDriveCirculation = new function() { > } > }); > } >- }) ); >+ }, "checkout") ); > } > else if (!item) { > $(el).append( ajax_button( __("Place hold"), function() { > item_action({action: "place-hold", id: id}, el, copies_available); >- }) ); >+ }, "placehold") ); > } > > if (item) { >@@ -384,27 +384,28 @@ KOHA.OverDriveCirculation = new function() { > if( confirm( __("Are you sure you want to cancel this hold?") ) ) { > item_action({action: "remove-hold", id: id}, el, copies_available); > } >- }) ); >+ }, "cancelhold") ); > } > return item; > } > } > >- function ajax_button(label, on_click) { >+ function ajax_button(label, on_click, uniqueName) { > var button = $('<a href="#">') > .click(function(e) { > e.preventDefault(); > on_click(); > }); >- decorate_button(button, label); >+ decorate_button(button, label, uniqueName); > return button; > } > >- function decorate_button(button, label) { >+ function decorate_button(button, label, uniqueName) { > $(button) > .addClass("btn btn-primary btn-sm") > .css("color","white") >- .text(label); >+ .text(label) >+ .attr('id',uniqueName); > } > > function checkout_format(el, id, formats, copies_available) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29845
:
129288
|
129324
|
129332
|
130633
|
130634
|
130662
|
130878