Attachment 129297 Details for Bug 29759 – Bug 29757: (QA follow-up) Remove abs from the test

[patch] Bug 29757: (QA follow-up) Remove abs from the test

Bug-29757-QA-follow-up-Remove-abs-from-the-test.patch (text/plain), 1.16 KB, created by Marcel de Rooy on 2022-01-11 14:33:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-01-11 14:33:49 UTC

Size: 1.16 KB

patch

obsolete

>From 5135830e89c72b3c5b87ba20d741adefb2bd5593 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 11 Jan 2022 14:31:27 +0000
>Subject: [PATCH] Bug 29757: (QA follow-up) Remove abs from the test
>Content-Type: text/plain; charset=utf-8
>
>Obviously abs has two sides, and we could allow wrong results. We
>can be more precise here.
>Trivial exercise.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/ArticleRequest.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/ArticleRequest.t b/t/db_dependent/Koha/ArticleRequest.t
>index b7bceb382e..9a5501bff2 100755
>--- a/t/db_dependent/Koha/ArticleRequest.t
>+++ b/t/db_dependent/Koha/ArticleRequest.t
>@@ -199,7 +199,7 @@ subtest 'cancel() tests' => sub {
>     is( $ar->cancellation_reason, $reason, 'Cancellation reason stored correctly' );
>     is( $ar->notes, $notes, 'Notes stored correctly' );
> 
>-    is( abs $patron->account->balance, $payed_amount, 'The patron has been refunded the right value' );
>+    is( $patron->account->balance, -$payed_amount, 'The patron has a credit balance' );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29759: 128874 | 128875 | 129162 | 129163 | 129181 | 129182 | 129297 | 129298 | 129302 | 129303 | 129304 | 130093 | 130094 | 130095 | 130096