Attachment 129399 Details for Bug 29874 – Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve

[patch] Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve

Bug-29874-Remove-unused-method-C4SIPILSItemfillres.patch (text/plain), 1.43 KB, created by Tomás Cohen Arazi (tcohen) on 2022-01-13 12:58:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-01-13 12:58:03 UTC

Size: 1.43 KB

patch

obsolete

>From 91f80121a8b3731b0468d5c6843a81c6c7cda566 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 13 Jan 2022 09:54:33 -0300
>Subject: [PATCH] Bug 29874: Remove unused method
> C4::SIP::ILS::Item::fill_reserve
>
>This patch removes the unused method.
>
>Likely a leftover from ancient ages. AddIssue already fills the hold and
>is called in the Checkout.pm library.
>
>To test:
>1. Run:
>   $ git grep fill_reserve
>=> FAIL: Notice it is only mentioned in the line that defines it
>2. Apply this patch
>3. Repeat 1
>=> SUCCESS: Removed.
>---
> C4/SIP/ILS/Item.pm | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
>index a85a557d00..a97eb62d35 100644
>--- a/C4/SIP/ILS/Item.pm
>+++ b/C4/SIP/ILS/Item.pm
>@@ -403,19 +403,6 @@ sub barcode_is_borrowernumber {    # because hold_queue only has borrowernumber.
>     return unless $converted;
>     return ($number == $converted);
> }
>-# FIXME: This methods is very likely not used. It's only reference in the codebase
>-#        is itself. I'm 'fixing' it so we can remove ModReserveFill. But filing a bug
>-#        for properly removing it.
>-sub fill_reserve {
>-    my $self = shift;
>-    my $hold = shift or return;
>-    foreach (qw(biblionumber borrowernumber reservedate)) {
>-        $hold->{$_} or return;
>-    }
>-
>-    my $hold_obj = Koha::Holds->find( $hold->id );
>-    return $hold_obj->fill;
>-}
> 
> =head2 build_additional_item_fields_string
> 
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 29874: 129399 | 129422 | 129601