Attachment 129412 Details for Bug 29877 – Bug 29877: Make POST /holds handle maxreserves correctly

[patch] Bug 29877: Make POST /holds handle maxreserves correctly

Bug-29877-Make-POST-holds-handle-maxreserves-corre.patch (text/plain), 1.42 KB, created by Tomás Cohen Arazi (tcohen) on 2022-01-13 15:16:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-01-13 15:16:20 UTC

Size: 1.42 KB

patch

obsolete

>From 43ec7a953ffc9278b8ee4f023d0c0a9814a70e4b Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 13 Jan 2022 12:10:30 -0300
>Subject: [PATCH] Bug 29877: Make POST /holds handle maxreserves correctly
>
>The current implementation doesn't consider the following values for the
>syspref: undef and 0.
>
>The tests mistakenly didn't cover them.
>
>To test:
>1. Apply the regression tests patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/api/v1/holds.t
>=> FAIL: Tests fail, obvious warnings about comparing undefined values
>         too.
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: Tests pass!
>5. You can try on Postman as well
>=> SUCCESS: Behavior is correct!
>6. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/REST/V1/Holds.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm
>index 0ca60b1459..e0c0501560 100644
>--- a/Koha/REST/V1/Holds.pm
>+++ b/Koha/REST/V1/Holds.pm
>@@ -169,7 +169,7 @@ sub add {
>             ? C4::Reserves::CanItemBeReserved( $patron_id, $item_id )
>             : C4::Reserves::CanBookBeReserved( $patron_id, $biblio_id );
> 
>-        if ( $patron->holds->count + 1 > C4::Context->preference('maxreserves') ) {
>+        if ( C4::Context->preference('maxreserves') && $patron->holds->count + 1 > C4::Context->preference('maxreserves') ) {
>             $can_place_hold->{status} = 'tooManyReserves';
>         }
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 29877: 129411 | 129412 | 129415 | 129416 | 131189 | 131190