Attachment 129453 Details for Bug 29483 – Bug 29843: Use in opac/opac-privacy.pl

[patch] Bug 29843: Use in opac/opac-privacy.pl

Bug-29843-Use-in-opacopac-privacypl.patch (text/plain), 1.85 KB, created by Andrew Fuerste-Henry on 2022-01-13 20:58:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2022-01-13 20:58:17 UTC

Size: 1.85 KB

patch

obsolete

>From 39c991d30596ee3ad406ebc406d6829507529d81 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 10 Jan 2022 11:44:07 -0300
>Subject: [PATCH] Bug 29843: Use in opac/opac-privacy.pl
>
>This patch makes the opac/opac-privacy.pl OPAC page use the new
>anonymize method.
>
>To test:
>1. Have some checked-in materiales
>2. Have OPACPrivacy enabled
>3. Notice your checkouts history contains what you expect
>4. Go to 'your privacy'
>5. Click on 'Delete checkout history'
>=> SUCCESS: It works, no crash.
>6. Sign off :-D
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=29483
>---
> opac/opac-privacy.pl | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/opac/opac-privacy.pl b/opac/opac-privacy.pl
>index 2c96b7ffa9..b3ba672afe 100755
>--- a/opac/opac-privacy.pl
>+++ b/opac/opac-privacy.pl
>@@ -40,13 +40,13 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
>     }
> );
> 
>-my $patron = Koha::Patrons->find( $borrowernumber );
>-
> my $op                         = $query->param("op");
> my $privacy                    = $query->param("privacy");
> my $privacy_guarantor_checkouts = $query->param("privacy_guarantor_checkouts");
> my $privacy_guarantor_fines     = $query->param("privacy_guarantor_fines");
> 
>+my $patron = Koha::Patrons->find( $borrowernumber );;
>+
> if ( $op eq "update_privacy" ) {
>     if ( $patron ) {
>         $patron->set({
>@@ -69,10 +69,7 @@ elsif ( $op eq "delete_record" ) {
>     if ( $all or $checkouts ) {
> 
>         # delete all reading records for items returned
>-        my $rows = eval {
>-            Koha::Patrons->search( { 'me.borrowernumber' => $borrowernumber } )
>-              ->anonymise_issue_history;
>-        };
>+        my $rows = eval { $patron->old_checkouts->anonymize + 0 };
> 
>         $template->param(
>             (
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29483: 127656 | 127819 | 127820 | 127883 | 127884 | 127885 | 129450 | 129451 | 129452 | 129453 | 129454 | 129499 | 129500 | 129501 | 132094 | 132095 | 132096 | 132113 | 133389 | 133390 | 133391 | 134723