Bugzilla – Attachment 129473 Details for
Bug 29403
dt_from_string should fail if passed more data than expected for the format
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29403: (QA follow-up) Add comments why test should fail
Bug-29403-QA-follow-up-Add-comments-why-test-shoul.patch (text/plain), 1.36 KB, created by
Marcel de Rooy
on 2022-01-14 10:35:39 UTC
(
hide
)
Description:
Bug 29403: (QA follow-up) Add comments why test should fail
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-01-14 10:35:39 UTC
Size:
1.36 KB
patch
obsolete
>From e2ca9ffd414772eb7548f91d631bb26eb8781879 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 14 Jan 2022 10:19:02 +0000 >Subject: [PATCH] Bug 29403: (QA follow-up) Add comments why test should fail >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/DateUtils.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/DateUtils.t b/t/DateUtils.t >index 447d75ffed..97cffd7509 100755 >--- a/t/DateUtils.t >+++ b/t/DateUtils.t >@@ -138,12 +138,12 @@ $dt0 = dt_from_string( '2012-01-01T23:59:59.999+02:00', 'rfc3339' ); > cmp_ok( $dt0->epoch(), 'eq', '1325455199', 'dt_from_string handles seconds with 3 decimal places and a timezone' ); > > eval { >- $dt0 = dt_from_string( '2012-01-01T23:59:59.999Z+02:00', 'rfc3339' ); >+ $dt0 = dt_from_string( '2012-01-01T23:59:59.999Z+02:00', 'rfc3339' ); # Do not combine Z with +02 ! > }; > like( $@, qr/.*does not match the date format \(rfc3339\).*/, 'dt_from_string should die when passed a bad rfc3339 date string' ); > > eval { >- $dt0 = dt_from_string('2021-11-03T10:16:59Z+00:00', 'iso'); >+ $dt0 = dt_from_string('2021-11-03T10:16:59Z+00:00', 'iso'); # Z and +00 are the same, but should not be together > }; > like( $@, qr/.*does not match the date format \(iso\).*/, 'dt_from_string should die when passed a bad iso date string' ); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29403
:
127246
|
127247
|
127254
|
128076
|
128077
|
128078
|
128272
|
128273
|
128274
|
128450
|
128451
|
128452
|
128825
|
128826
|
128827
|
128828
|
128829
|
129373
|
129374
|
129375
|
129376
|
129391
|
129392
|
129393
|
129394
|
129473
|
129486
|
129487
|
129488
|
129552
|
129553
|
129554
|
129555
|
129556