Attachment 129474 Details for Bug 28786 – Bug 28786: Don't pass unecessary secret to constructor

[patch] Bug 28786: Don't pass unecessary secret to constructor

Bug-28786-Dont-pass-unecessary-secret-to-construct.patch (text/plain), 1.95 KB, created by Jonathan Druart on 2022-01-14 12:14:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-14 12:14:26 UTC

Size: 1.95 KB

patch

obsolete

>From f5f184174f2b6b0678b7688dc501c1c322aaa225 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 14 Jan 2022 12:42:59 +0100
>Subject: [PATCH] Bug 28786: Don't pass unecessary secret to constructor
>
>This is a leftover what a misunderstanding I had at first reading the module's pod,
>generate_secret32 does not generate the base-32 version of the secret we passed in
>parameter to the constructor.
>---
> Koha/Auth/TwoFactorAuth.pm | 6 ++----
> members/two_factor_auth.pl | 3 +--
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/Koha/Auth/TwoFactorAuth.pm b/Koha/Auth/TwoFactorAuth.pm
>index 89320067638..19fa7e46b72 100644
>--- a/Koha/Auth/TwoFactorAuth.pm
>+++ b/Koha/Auth/TwoFactorAuth.pm
>@@ -28,9 +28,7 @@ Koha::Auth::TwoFactorAuth- Koha class deal with Two factor authentication
> 
> use Koha::Auth::TwoFactorAuth;
> 
>-my $secret = Koha::AuthUtils::generate_salt( 'weak', 16 );
>-my $auth = Koha::Auth::TwoFactorAuth->new(
>-    { patron => $patron, secret => $secret } );
>+my $auth = Koha::Auth::TwoFactorAuth->new({ patron => $patron });
> my $secret32 = $auth->generate_secret32;
> my $ok = $auth->verify($pin_code, 1, $secret32);
> 
>@@ -40,7 +38,7 @@ It's based on Auth::GoogleAuth
> 
> =head3 new
> 
>-    $obj = Koha::Auth::TwoFactorAuth->new({ patron => $p, secret => $s });
>+    $obj = Koha::Auth::TwoFactorAuth->new({ patron => $p, [secret => $secret], [secret32 => $secret32] });
> 
> =cut
> 
>diff --git a/members/two_factor_auth.pl b/members/two_factor_auth.pl
>index 2a5a996c566..159e2fd992a 100755
>--- a/members/two_factor_auth.pl
>+++ b/members/two_factor_auth.pl
>@@ -74,9 +74,8 @@ if ( $op eq 'register-2FA' ) {
> 
> if ( $op eq 'enable-2FA' ) {
> 
>-    my $secret = Koha::AuthUtils::generate_salt( 'weak', 16 );
>     my $auth = Koha::Auth::TwoFactorAuth->new(
>-        { patron => $logged_in_user, secret => $secret } );
>+        { patron => $logged_in_user } );
> 
>     my $secret32 = $auth->generate_secret32;
>     my $qr_code_url =
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28786: 123375 | 123376 | 123377 | 123378 | 123379 | 123380 | 123381 | 123397 | 123398 | 123399 | 123400 | 123401 | 123402 | 123403 | 124569 | 124770 | 124771 | 124844 | 124845 | 124846 | 124847 | 128841 | 128842 | 129383 | 129384 | 129474 | 129521 | 129557 | 129558 | 129559 | 129560 | 129561 | 129562 | 129563 | 129564 | 129565 | 129566 | 129567 | 129568 | 129569 | 129654 | 129655 | 129656 | 129657 | 129658 | 129659 | 129660 | 129661 | 129662 | 129665 | 131940 | 131941 | 131942 | 131943 | 131944 | 131945 | 131946 | 131947 | 131948 | 131949 | 131950 | 131951 | 131952 | 131953 | 131954 | 131955 | 131956 | 131957 | 131958 | 132142 | 132143 | 132144 | 132145 | 132146 | 132147 | 132148 | 132149 | 132150 | 132153 | 132154 | 132155 | 132156 | 132157 | 133222 | 133516 | 133522 | 133531 | 133533 | 133541 | 133548 | 133643 | 133686