Bugzilla – Attachment 129485 Details for
Bug 21652
reserves.waitingdate is set to current date by printing new hold slip
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21652: Only set waitingdate to today if there is no waitingdate already
Bug-21652-Only-set-waitingdate-to-today-if-there-i.patch (text/plain), 1.28 KB, created by
Nick Clemens (kidclamp)
on 2022-01-14 14:20:26 UTC
(
hide
)
Description:
Bug 21652: Only set waitingdate to today if there is no waitingdate already
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-01-14 14:20:26 UTC
Size:
1.28 KB
patch
obsolete
>From 6be6fc137597b11c0f22a5808db930503061ebc0 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 6 Jan 2022 15:16:05 +0000 >Subject: [PATCH] Bug 21652: Only set waitingdate to today if there is no > waitingdate already > >1- Find or create a hold with a waitingdate other than today >2- Check the item in to generate a new hold alert >3- Select "Confirm and Print" >4- Verify that the waiting date has changed to the current date >5- Apply patch >6- Try 1-3 again, if a waitingdate already exists it should not change >7. Try an item with no waitingdate, it should properly update to today > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > Koha/Hold.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 9736dc527f..104ebe94ac 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -178,10 +178,18 @@ sub set_waiting { > > $self->priority(0); > >+ my $waiting_date; > my $today = dt_from_string(); >+ >+ if ( $self->waitingdate ) { >+ $waiting_date = $self->waitingdate; >+ } else { >+ $waiting_date = $today->ymd; >+ } >+ > my $values = { > found => 'W', >- waitingdate => $today->ymd, >+ waitingdate => $waiting_date, > desk_id => $desk_id, > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21652
:
129099
|
129100
|
129484
|
129485
|
129635
|
129636
|
129637