Bugzilla – Attachment 129487 Details for
Bug 29403
dt_from_string should fail if passed more data than expected for the format
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29403: Fix unit test for bug 29718
Bug-29403-Fix-unit-test-for-bug-29718.patch (text/plain), 1.23 KB, created by
Jonathan Druart
on 2022-01-14 14:25:11 UTC
(
hide
)
Description:
Bug 29403: Fix unit test for bug 29718
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-01-14 14:25:11 UTC
Size:
1.23 KB
patch
obsolete
>From ae404944cf0ffb9302bd5ec966aa8552af5edcc7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 21 Dec 2021 11:44:44 +0000 >Subject: [PATCH] Bug 29403: Fix unit test for bug 29718 > >Including a 'T' is actually valid for ISO date format, I was being >naughty and writing the test to follow our code rather than writing the >test to conform to the ISO spec first time around. Now we are properly >supporting 'T' in ISO dates with bug 29718, we need to update the test >here to properly reflect an invalid ISO date string. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/DateUtils.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/DateUtils.t b/t/DateUtils.t >index 3aae15162ec..447d75ffeda 100755 >--- a/t/DateUtils.t >+++ b/t/DateUtils.t >@@ -143,7 +143,7 @@ eval { > like( $@, qr/.*does not match the date format \(rfc3339\).*/, 'dt_from_string should die when passed a bad rfc3339 date string' ); > > eval { >- $dt0 = dt_from_string('2021-11-03T10:16:59+00:00', 'iso'); >+ $dt0 = dt_from_string('2021-11-03T10:16:59Z+00:00', 'iso'); > }; > like( $@, qr/.*does not match the date format \(iso\).*/, 'dt_from_string should die when passed a bad iso date string' ); > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29403
:
127246
|
127247
|
127254
|
128076
|
128077
|
128078
|
128272
|
128273
|
128274
|
128450
|
128451
|
128452
|
128825
|
128826
|
128827
|
128828
|
128829
|
129373
|
129374
|
129375
|
129376
|
129391
|
129392
|
129393
|
129394
|
129473
|
129486
|
129487
|
129488
|
129552
|
129553
|
129554
|
129555
|
129556