Attachment 129521 Details for Bug 28786 – Bug 28786: Don't rely on Auth::GoogleAuth to generate the secret

[patch] Bug 28786: Don't rely on Auth::GoogleAuth to generate the secret

Bug-28786-Dont-rely-on-AuthGoogleAuth-to-generate-.patch (text/plain), 1.07 KB, created by Jonathan Druart on 2022-01-17 10:10:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-17 10:10:41 UTC

Size: 1.07 KB

patch

obsolete

>From 33d0dfcdbb433917a7a1bffd5d59620cceb4ea76 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 17 Jan 2022 11:06:30 +0100
>Subject: [PATCH] Bug 28786: Don't rely on Auth::GoogleAuth to generate the
> secret
>
>---
> members/two_factor_auth.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/members/two_factor_auth.pl b/members/two_factor_auth.pl
>index 159e2fd992a..03393f949d1 100755
>--- a/members/two_factor_auth.pl
>+++ b/members/two_factor_auth.pl
>@@ -18,6 +18,7 @@
> use Modern::Perl;
> 
> use CGI;
>+use Convert::Base32 qw( encode_base32 );
> 
> use C4::Auth qw( get_template_and_user );
> use C4::Output qw( output_and_exit output_html_with_http_headers );
>@@ -77,7 +78,7 @@ if ( $op eq 'enable-2FA' ) {
>     my $auth = Koha::Auth::TwoFactorAuth->new(
>         { patron => $logged_in_user } );
> 
>-    my $secret32 = $auth->generate_secret32;
>+    my $secret32 = encode_base32(Koha::AuthUtils::generate_salt("strong", 32));
>     my $qr_code_url =
>       $auth->qr_code( $secret32, $auth->key_id, $auth->issuer, );
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28786: 123375 | 123376 | 123377 | 123378 | 123379 | 123380 | 123381 | 123397 | 123398 | 123399 | 123400 | 123401 | 123402 | 123403 | 124569 | 124770 | 124771 | 124844 | 124845 | 124846 | 124847 | 128841 | 128842 | 129383 | 129384 | 129474 | 129521 | 129557 | 129558 | 129559 | 129560 | 129561 | 129562 | 129563 | 129564 | 129565 | 129566 | 129567 | 129568 | 129569 | 129654 | 129655 | 129656 | 129657 | 129658 | 129659 | 129660 | 129661 | 129662 | 129665 | 131940 | 131941 | 131942 | 131943 | 131944 | 131945 | 131946 | 131947 | 131948 | 131949 | 131950 | 131951 | 131952 | 131953 | 131954 | 131955 | 131956 | 131957 | 131958 | 132142 | 132143 | 132144 | 132145 | 132146 | 132147 | 132148 | 132149 | 132150 | 132153 | 132154 | 132155 | 132156 | 132157 | 133222 | 133516 | 133522 | 133531 | 133533 | 133541 | 133548 | 133643 | 133686