Attachment 129533 Details for Bug 29895 – Bug 29895: Fix 'add multiple items' button on neworderempty

[patch] Bug 29895: Fix 'add multiple items' button on neworderempty

Bug-29895-Fix-add-multiple-items-button-on-neworde.patch (text/plain), 3.03 KB, created by Jonathan Druart on 2022-01-17 14:22:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-17 14:22:08 UTC

Size: 3.03 KB

patch

obsolete

>From eb63ec6f7afa09b9156d245b6bea8264c81f23cc Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 17 Jan 2022 15:01:56 +0100
>Subject: [PATCH] Bug 29895: Fix 'add multiple items' button on neworderempty
>
>Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket
>
>It has a "visibility: hidden" we are trying to remove setting "display:
>inline"
>
>This is pretty ugly and certainly does not clean the code, but it's too
>messy and this patch fixes the problem easily.
>
>Test plan:
>Add a new order
>Click "Add multiple items", enter "2", click "Add".
>Confirm that you can use the "Add multiple items" again.
>---
> koha-tmpl/intranet-tmpl/prog/js/additem.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/additem.js b/koha-tmpl/intranet-tmpl/prog/js/additem.js
>index 7d80ca8a775..a83310f29d4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/additem.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/additem.js
>@@ -180,10 +180,10 @@ function cloneItemBlock(index, unique_item_fields, callback) {
>             var buttonPlus = "<fieldset class=\"action\">";
>             buttonPlus += '<input type="button" class="addItemControl" name="buttonPlus" style="cursor:pointer; margin:0 1em;" onclick="addItem(this,\'' + unique_item_fields + '\')" value="' + ( __("Add item") )+ '" />';
>             buttonPlus += '<input type="button" class="addItemControl cancel" name="buttonClear" style="cursor:pointer;" onclick="clearItemBlock(this)" value="' + __("Clear") + '" />';
>-            buttonPlus += '<input type="button" class="addItemControl" name="buttonPlusMulti" onclick="javascript:this.nextSibling.style.display=\'inline\'; return false;" style="cursor:pointer; margin:0 1em;" value="' + __("Add multiple items") + '" />';
>+            buttonPlus += '<input type="button" class="addItemControl" name="buttonPlusMulti" onclick="javascript:this.nextSibling.style.display=\'inline\'; this.nextSibling.style.visibility=\'visible\'; return false;" style="cursor:pointer; margin:0 1em;" value="' + __("Add multiple items") + '" />';
>             buttonPlus += '<span id="add_multiple_copies" style="display:none">'
>                 +     '<input type="text" inputmode="numeric" pattern="[0-9]*" class="addItemControl" id="multiValue" name="multiValue" placeholder="' + __("Number of items to add") + '" />'
>-                +     '<input type="button" class="addItemControl" name=buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + __("Add") + '" />'
>+                +     '<input type="button" class="addItemControl" name="buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + __("Add") + '" />'
>                 +     '<div class="dialog message">' + __("NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied") + '</div>'
>                 + '</span>';
>             buttonPlus += "</fieldset>";
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29895: 129533 | 129572 | 130023