Attachment 129551 Details for Bug 29884 – Bug 29884: Run missing test in api/v1/patrons.t

[patch] Bug 29884: Run missing test in api/v1/patrons.t

Bug-29884-Run-missing-test-in-apiv1patronst.patch (text/plain), 1.59 KB, created by Marcel de Rooy on 2022-01-18 12:13:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-01-18 12:13:35 UTC

Size: 1.59 KB

patch

obsolete

>From c34823fa3314206579a46daed547dcb24bfcc5c4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 14 Jan 2022 15:17:56 +0100
>Subject: [PATCH] Bug 29884: Run missing test in api/v1/patrons.t
>Content-Type: text/plain; charset=utf-8
>
>compare is not calling is() or ok(), it's caller job to do it.
>
>Test plan:
>  prove t/db_dependent/api/v1/patrons.t
>should still return green
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/api/v1/patrons.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/patrons.t b/t/db_dependent/api/v1/patrons.t
>index b7e65dc91c..dc8e56a00b 100755
>--- a/t/db_dependent/api/v1/patrons.t
>+++ b/t/db_dependent/api/v1/patrons.t
>@@ -545,7 +545,7 @@ subtest 'update() tests' => sub {
>     $schema->storage->txn_rollback;
> 
>     subtest 'librarian access tests' => sub {
>-        plan tests => 44;
>+        plan tests => 45;
> 
>         $schema->storage->txn_begin;
> 
>@@ -659,7 +659,7 @@ subtest 'update() tests' => sub {
>         my $updated_on_got = delete $got->{updated_on};
>         my $updated_on_expected = delete $newpatron->{updated_on};
>         is_deeply($got, $newpatron, 'Returned patron from update matches expected');
>-        t::lib::Dates::compare( $updated_on_got, $updated_on_expected, 'updated_on values matched' );
>+        is( t::lib::Dates::compare( $updated_on_got, $updated_on_expected ), 0, 'updated_on values matched' );
> 
>         is(Koha::Patrons->find( $patron_2->id )->cardnumber,
>            $newpatron->{ cardnumber }, 'Patron is really updated!');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29884: 129482 | 129551