Attachment 129589 Details for Bug 29797 – Bug 29797: Fix display of itemnumbers on the background job detail view

[patch] Bug 29797: Fix display of itemnumbers on the background job detail view

Bug-29797-Fix-display-of-itemnumbers-on-the-backgr.patch (text/plain), 2.02 KB, created by Fridolin Somers on 2022-01-18 19:05:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-01-18 19:05:50 UTC

Size: 2.02 KB

patch

obsolete

>From da54c4ea5ea76e16aed77fba5ea967747ed39962 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 5 Jan 2022 10:38:27 +0100
>Subject: [PATCH] Bug 29797: Fix display of itemnumbers on the background job
> detail view
>
>If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers.
>Also add a space character between itemnumbers.
>
>Test plan:
>1. Check an item out
>2. Use the batch delete items tool to delete the item that is checked
>out and another one.
>3. On the confirmation view, use the dev tool of your browser to remove
>the "disabled" property of the disabled checkbox and select both
>items.
>4. Submit
>5. Go to the detail view of the background job and confirm that you see
>the itemnumber of the item that has failed to be deleted
>
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>---
> .../en/includes/background_jobs/batch_item_record_deletion.inc  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc
>index c4d677918a..85a4b806b0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_item_record_deletion.inc
>@@ -14,7 +14,7 @@
> 
>         [% IF report.not_deleted_itemnumbers.size %]
>             <div class="dialog error">
>-                [% report.not_deleted_itemnumbers.size | html %] item(s) could not be deleted: [% FOREACH not_deleted_itemnumber IN not_deleted_itemnumbers %][% not_deleted_itemnumber.itemnumber | html %][% END %]
>+                [% report.not_deleted_itemnumbers.size | html %] item(s) could not be deleted: [% FOREACH not_deleted_itemnumber IN report.not_deleted_itemnumbers %][% not_deleted_itemnumber | html %] [% END %]
>             </div>
>         [% END %]
> 
>-- 
>2.34.0

Actions: View | Diff | Splinter Review

Attachments on bug 29797: 129019 | 129588 | 129589 | 129599