Attachment 129592 Details for Bug 29889 – Bug 29889: Incorrect library check in patron message deletion logic

[patch] Bug 29889: Incorrect library check in patron message deletion logic

Bug-29889-Incorrect-library-check-in-patron-messag.patch (text/plain), 2.36 KB, created by Jonathan Druart on 2022-01-19 10:18:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-19 10:18:26 UTC

Size: 2.36 KB

patch

obsolete

>From 114aa1e3919b7f39f54b933327e893c50d7d0400 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 14 Jan 2022 19:39:02 +0000
>Subject: [PATCH] Bug 29889: Incorrect library check in patron message deletion
> logic
>
>This patch corrects the logic controlling whether a patron message on
>the circulation or patron details page has a "Delete" link. An error in
>the logic prevented messages from being removed by staff who should have
>been authorized to do so.
>
>To reproduce the bug, check that your AllowAllMessageDeletion preference
>is disabled.
>
>- In the staff client, check out to a patron whose home library doesn't
> match the library you're logged in at.
>- Add a message to the patron's account.
>- You should see no "Delete" link next to the newly-added message.
> - If you edit the patron so that their home library matches the
> library you're logged in at the delete link will appear.
>
>To test, apply the patch and follow the steps above. The delete link
>should aways appear if the message was left by someone logged in at the
>same library.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>index 72e747bd141..0c1d8f88dc7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>@@ -217,7 +217,7 @@
> [% END %]
> "[% patron_message.message | html %]"
> 
>- [% IF patron_message.branchcode == patron.branchcode OR Koha.Preference('AllowAllMessageDeletion') %]
>+ [% IF patron_message.branchcode == Branches.GetLoggedInBranchcode OR Koha.Preference('AllowAllMessageDeletion') %]
> <a class="btn btn-link" href="/cgi-bin/koha/circ/del_message.pl?message_id=[% patron_message.message_id | html %]&amp;borrowernumber=[% patron_message.borrowernumber | html %]&amp;from=moremember" onclick='return confirm(_("Are you sure you want to delete this message? This cannot be undone."));'> Delete</a>
> [% END %]
> </li>
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29889: 129514 | 129592