Bugzilla – Attachment 129646 Details for
Bug 26537
Search does not work when no term in value_builder/unimarc_field_4XX.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query
Bug-26537-use-QueryBuilder-in-unimarcfield4XX-plug.patch (text/plain), 2.23 KB, created by
Owen Leonard
on 2022-01-20 12:13:53 UTC
(
hide
)
Description:
Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-01-20 12:13:53 UTC
Size:
2.23 KB
patch
obsolete
>From c59f4f18caa66b69845a0c61cad15f9ba232fe4b Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Thu, 1 Oct 2020 15:01:02 +0000 >Subject: [PATCH] Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to > make query > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > cataloguing/value_builder/unimarc_field_4XX.pl | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl >index 83dcaf3c8c..8e80c64fe4 100755 >--- a/cataloguing/value_builder/unimarc_field_4XX.pl >+++ b/cataloguing/value_builder/unimarc_field_4XX.pl >@@ -34,6 +34,7 @@ use Koha::ItemTypes; > > use Koha::SearchEngine; > use Koha::SearchEngine::Search; >+use Koha::SearchEngine::QueryBuilder; > > sub plugin_parameters { > my ( $dbh, $record, $tagslib, $i ) = @_; >@@ -337,10 +338,13 @@ sub plugin { > my $startfrom = $query->param('startfrom'); > my $resultsperpage = $query->param('resultsperpage') || 20; > my $orderby; >- my $op = 'and'; >- $search = 'kw:'.$search." $op mc-itemtype:".$itype if $itype; >+ my $limits = $itype ? ["mc-itype,phr:$itype"] : []; >+ >+ my $builder = Koha::SearchEngine::QueryBuilder->new({index => $Koha::SearchEngine::BIBLIOS_INDEX}); > my $searcher = Koha::SearchEngine::Search->new({index => $Koha::SearchEngine::BIBLIOS_INDEX}); >- my ( $errors, $results, $total_hits ) = $searcher->simple_search_compat($search, $startfrom * $resultsperpage, $resultsperpage ); >+ >+ my ($builderror, $es_query)= $builder->build_query_compat( undef, [$search], ['kw'], $limits, ['relevance']); >+ my ( $errors, $results, $total_hits ) = $searcher->simple_search_compat($es_query, $startfrom * $resultsperpage, $resultsperpage ); > if (defined $errors ) { > $results = []; > } >@@ -437,7 +441,7 @@ sub plugin { > if ( $total_hits < $from + $resultsperpage ) { > $to = $total_hits; > }else{ >- $to = $from + $resultsperpage ; >+ $to = $startfrom * $resultsperpage + $resultsperpage ; > } > my $defaultview = > 'BiblioDefaultView' . C4::Context->preference('BiblioDefaultView'); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26537
:
110756
|
111049
|
128930
|
128931
|
128932
|
128933
|
128934
|
128937
|
128938
|
129607
|
129646
|
129647
|
144858
|
144859