Bugzilla – Attachment 129664 Details for
Bug 29914
check_cookie_auth not strict enough
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29914: Make check_cookie_auth compare the userid
Bug-29914-Make-checkcookieauth-compare-the-userid.patch (text/plain), 2.99 KB, created by
Jonathan Druart
on 2022-01-20 14:39:46 UTC
(
hide
)
Description:
Bug 29914: Make check_cookie_auth compare the userid
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-01-20 14:39:46 UTC
Size:
2.99 KB
patch
obsolete
>From 2829371f54c129f5caefc5d91f19e8fe7a15c8b1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 20 Jan 2022 10:10:05 +0100 >Subject: [PATCH] Bug 29914: Make check_cookie_auth compare the userid > >check_cookie_auth is assuming that the user is authenticated if a cookie exists >and that the login/username exists in the DB. > >So basically if you hit the login page, fill the login input with a >valid username, click "login" >=> A cookie will be generated, and the sessions table will contain a >line with this session id. >On the second hit, if the username is in the DB, it will be enough to be >considered authenticated. >--- > C4/Auth.pm | 15 +++++++++------ > Koha/REST/V1/Auth.pm | 7 ++++--- > 2 files changed, 13 insertions(+), 9 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 1cfeed48cc4..823cb56c3a5 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1622,6 +1622,8 @@ Possible return values in C<$status> are: > > =item "ok" -- user authenticated; C<$sessionID> have valid values. > >+=item "anon" -- user not authenticated but valid for anonymous session. >+ > =item "failed" -- credentials are not correct; C<$sessionid> are undef > > =item "maintenance" -- DB is in maintenance mode; no login possible at the moment >@@ -1700,18 +1702,19 @@ sub check_cookie_auth { > $session->flush; > C4::Context->_unset_userenv($sessionID); > return ( "restricted", undef, { old_ip => $ip, new_ip => $remote_addr}); >- } else { >+ } elsif ( $userid ) { > $session->param( 'lasttime', time() ); > my $flags = defined($flagsrequired) ? haspermission( $userid, $flagsrequired ) : 1; > if ($flags) { > return ( "ok", $session ); >- } else { >- $session->delete(); >- $session->flush; >- C4::Context->_unset_userenv($sessionID); >- return ( "failed", undef ); > } >+ } else { >+ return ( "anon", $session ); > } >+ $session->delete(); >+ $session->flush; >+ C4::Context->_unset_userenv($sessionID); >+ return ( "failed", undef ); > } else { > return ( "expired", undef ); > } >diff --git a/Koha/REST/V1/Auth.pm b/Koha/REST/V1/Auth.pm >index 01eef3375e5..7bbf97fc057 100644 >--- a/Koha/REST/V1/Auth.pm >+++ b/Koha/REST/V1/Auth.pm >@@ -223,9 +223,10 @@ sub authenticate_api_request { > $cookie, undef, > { remote_addr => $remote_addr }); > if ($status eq "ok") { >- $user = Koha::Patrons->find( $session->param('number') ) >- unless $session->param('sessiontype') >- and $session->param('sessiontype') eq 'anon'; >+ $user = Koha::Patrons->find( $session->param('number') ); >+ $cookie_auth = 1; >+ } >+ elsif ($status eq "anon") { > $cookie_auth = 1; > } > elsif ($status eq "maintenance") { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29914
:
129634
|
129643
|
129652
|
129664
|
129682
|
129693
|
129694
|
129718
|
129719
|
129720
|
129725
|
129726
|
129727
|
129728
|
129729
|
129742
|
129743