Bugzilla – Attachment 129715 Details for
Bug 28993
Switch magnifying glass in staff detail pages to FA icon
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28993: Switch magnifying class in staff detail pages to FA icon
Bug-28993-Switch-magnifying-class-in-staff-detail-.patch (text/plain), 11.26 KB, created by
David Nind
on 2022-01-23 20:53:33 UTC
(
hide
)
Description:
Bug 28993: Switch magnifying class in staff detail pages to FA icon
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-01-23 20:53:33 UTC
Size:
11.26 KB
patch
obsolete
>From 6b3f3c05b8a75aa2173445416f8c0183cc977602 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 12 Jan 2022 16:29:27 +0000 >Subject: [PATCH] Bug 28993: Switch magnifying class in staff detail pages to > FA icon > >This patch modifies the staff interface's bibliographic detail XSL so >that a Font Awesome is used instead of a magnifying glass image when >listing authority subject headings. > >The patch also corrects two other places where the image is used so that >the image can be removed. Some markup from authorities.detail.tt is >removed because it appears to be unused (a copy and paste from >catalogue/detail.tt). > >To test, apply the patch and rebuild the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > >- To view the changes to the staff interface bibliographic detail page, > locate a record which has at least one subject heading which is linked > to a subject authority record. >- The subject heading link should be followed by a magifying glass > (Font Awesome) icon which links to the authority record's detail page. >- View a similar change to the MARC detail page for the record. Confirm > that the subject headings are followed by a link to the authority > detail page. >- Follow the authority search link to locate and view an authority > record. The information on the authority detail page should be > correct. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/css/src/staff-global.scss | 7 +++++++ > .../prog/en/modules/authorities/detail.tt | 8 -------- > .../prog/en/modules/catalogue/MARCdetail.tt | 8 +++++--- > .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 16 ++++++---------- > koha-tmpl/intranet-tmpl/prog/img/filefind.png | Bin 2479 -> 0 bytes > 5 files changed, 18 insertions(+), 21 deletions(-) > delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/filefind.png > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index fa3421dee1..9f66a8fe9c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -26,6 +26,13 @@ a { > } > } > >+ &.authlink { >+ background-color: #e6f0f2; >+ border-radius: 5px; >+ display: inline-block; >+ padding: 2px 4px; >+ } >+ > &.btn { > &:link, > &:visited { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >index 21ff0c23c9..679318ffa7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >@@ -106,14 +106,6 @@ > [% subfiel.marc_value | html %] > [% END %] > </span> >- [% IF ( subfiel.link ) %] >- <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&marclist=[% subfiel.link | uri %]&operator==&type=intranet&value=[% subfiel.marc_value |url %]"> >- <img src="[% interface | html %]/[% theme | html %]/images/filefind.png" height="15" title="Search on [% subfiel.marc_value | html %]"> >- </a> >- [% END %] >- [% IF ( subfiel.authority ) %] >- <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]" class="button">Auth</a> >- [% END %] > </div> <!-- /.subfield_content.marc_field --> > </div> <!-- /.auth_subfield --> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >index e2068693b1..f6be1b3d8f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >@@ -99,12 +99,14 @@ > <span class="desc" title="[% subfiel.long_desc | html %]">[% subfiel.short_desc | html %]</span></span> > [% IF ( subfiel.is_url ) %]<a href="[% subfiel.marc_value | url %]">[% subfiel.marc_value | html %]</a>[% ELSE %][% subfiel.marc_value | html %][% END %] > [% IF ( subfiel.link ) %] >- <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&idx=[% subfiel.link | uri %],phr&type=intranet&q=[% subfiel.link | uri %],phr:[% subfiel.marc_value |uri %]"> >- <img src="[% interface | html %]/[% theme | html %]/img/filefind.png" height="15" title="Search on [% subfiel.marc_value | html %]" alt="Search on [% subfiel.marc_value | html %]" /> >+ <a class="authlink" href="/cgi-bin/koha/catalogue/search.pl?op=do_search&idx=[% subfiel.link | uri %],phr&type=intranet&q=[% subfiel.link | uri %],phr:[% subfiel.marc_value |uri %]"> >+ <i class="fa fa-link" aria-label="Search on [% subfiel.marc_value | html %]" title="Search on [% subfiel.marc_value | html %]"></i> > </a> > [% END %] > [% IF ( subfiel.authority ) %] >- <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]" class="button">Auth</a> >+ <a class="authlink" href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]"> >+ <i class="fa fa-search" area-label="View authority record" title="View authority record"></i> >+ </a> > [% END %] > </p> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 6983988867..7f14c298f6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -688,11 +688,9 @@ > <xsl:text> </xsl:text> > <a class='authlink'> > <xsl:attribute name="href">/cgi-bin/koha/authorities/detail.pl?authid=<xsl:value-of select="str:encode-uri(marc:subfield[@code=9], true())"/></xsl:attribute> >- <xsl:element name="img"> >- <xsl:attribute name="src">/intranet-tmpl/prog/img/filefind.png</xsl:attribute> >- <xsl:attribute name="alt"></xsl:attribute> >- <xsl:attribute name="height">15</xsl:attribute> >- <xsl:attribute name="width">15</xsl:attribute> >+ <xsl:element name="i"> >+ <xsl:attribute name="class">fa fa-search</xsl:attribute> >+ <xsl:attribute name="aria-label">View authority record</xsl:attribute> > </xsl:element> > </a> > </xsl:if> >@@ -740,11 +738,9 @@ > <xsl:text> </xsl:text> > <a class='authlink'> > <xsl:attribute name="href">/cgi-bin/koha/authorities/detail.pl?authid=<xsl:value-of select="str:encode-uri(marc:subfield[@code=9], true())"/></xsl:attribute> >- <xsl:element name="img"> >- <xsl:attribute name="src">/intranet-tmpl/prog/img/filefind.png</xsl:attribute> >- <xsl:attribute name="alt"></xsl:attribute> >- <xsl:attribute name="height">15</xsl:attribute> >- <xsl:attribute name="width">15</xsl:attribute> >+ <xsl:element name="i"> >+ <xsl:attribute name="class">fa fa-search</xsl:attribute> >+ <xsl:attribute name="aria-label">View authority record</xsl:attribute> > </xsl:element> > </a> > </xsl:if> >diff --git a/koha-tmpl/intranet-tmpl/prog/img/filefind.png b/koha-tmpl/intranet-tmpl/prog/img/filefind.png >deleted file mode 100644 >index 3c05c72b5eaeab4938ee64e3ac09632f5dceebae..0000000000000000000000000000000000000000 >GIT binary patch >literal 0 >HcmV?d00001 > >literal 2479 >zcmZ9Oc{tSj7stP5Y}v+*kdjGrGla2>WJrk2WND0TP$c_hEX_>T#3XCn8Y5(z%Ged5 >zL?lc0C6c0C*QA*&BiYJ&N5A_=zx#Zi^Lam?^Sqw-Ip?p>NyJ*2i3-UI0RSM1L7U*X >z3f&Dse(p^S4`1dAueXt<5db{u)Zt6|!hQ2!GB+~;c6JZFu_%q3*%O3zBytt~GtPAR >z8SEyn1Q~gA75X#c*K=|KK)?-SVq}YNZGTHhkQ>=A@O4Lb$smN&do}xGLstMP?dW@Y >zBH_5TP9kl_{*uY~Ai_A7-+#lDg2&#HRK``>!Uau@tK`=)45YjXwdP6t6HMam!mtNN >zvyp)t)Q=xNHb$)V=VocKdUdxdW9%_$WoOpo<K4VuKI_D@)FCg69)~O#l)IcvSX@+6 >z6nt)Hgq5ix__ZNd6c{v~?+L`<ObvtMCqMc-l$p*=G=lSWKD{{S5;pCS;9eN-7Us;D >zS}0kw=RCSGeQTzEkN73FEHcGI#WK6Xo<*Wo>QH0l-jGico;ruFf9W`NYH~W`FJ6{H >zu`MNoUtpt&^&^TLbNir+s%Y6m<uTe`Lv3k3w3K5lXhfT8mU4!8ttgGdpjiRUsd7j1 >z<tn+2dSnT<R4%XI)joDb)q~&mo%|!b-4VC0!X~~t*#sWwK5Snq)<&yJ!MbM#lJMFG >zdF`)1Oi$5iF4`jC2M<~=fZ552ZIG7MQvK{0LR4g#Q$GZws5%cf%}zwg(g-P7@x1FW >z-N7y%Bf~k0)duIA@1a$gI}s+<`t3pc{f%lBW{mizRt3N(82O^I;%U)l?;8p=cj8|0 >zTUQO@o^IY-m}m^NE5-yAECvHj?u8ZO&p7RQ|KhVPu7Y1rm@lGeK{|*%82=GmSSXvy >z#7EHg*B)c%i_U0kF`*d#0uXw7C^_vQJAvV@9D{UK9@Xg+R`JpBWxKq5ucf8s>Ts3} >z2|DPP?hthR&w-vdr4Tl*1ub(+9qMIBRlORla4Ip8PrL|lr^hWgx@(1Xkmt!y2m#Po >z5=32u&~~LfuLrZ@l%`u@1<ERb1`CmJ(6cdO4c7b7ir_?<K}<B<u^u5g(&5CRxap-5 >zoU@Pn<5Siq^oI5sItU#(51+*iH-&Q^%?*K1uQz`_>~2|M5?MlL>B3o9nlYMB?e_xQ >zAcK+>JP5mfR+nAdiMP=0QTn}gp(*0s+-#Z01(2<Vm1bMcH<-hhFUgz6diD|_Yrau| >zSyGW1GI!(73$|&T&IwMx-b}KfnICe*DD4>*aZ*65!C<sfTq#m%iDMt_O~GWf4#m1$ >z(O#xW2CGmtQ)@<IsCz3_K{nuE6~j@%y@l%IxFrcu-2gT_m{8A;6B07L(K+t;$}_Kr >z6Aoo=KFA?X_|=x#$vd@=Vuj%)8QPD_&-z|Nvy;S0bZHML?-z*Co%q;gJ0+zsT8D*Y >zPQGM(Pq;EkS^G|+#DKwu+#S}(dEVTrxu7?k-Wwi~(8nl6^LAX(j15j$@DCoWGAIv> >z=cfZ6ktIJ4N(>@FB}fHg9)wSLr7m~L{@D80+>q^rqCDAov0E_z@{uGfKD(vY*z=q< >zp;i_MQvBUe6)5GIY=~wcPB!ya%79UP1t1y4QuzIeN3q2NeYI-Z*{_v4s_G}=>RJ27 >zax>?blKjmX<Zpf`X9H)_EU`%#rv|cve6?)8uLGbiVxbv^-S?<s#M%Bgm1@N5_x>*$ >zE5%b90@i?Td>jk|=^J>uIv%D6l{R>H230*x5uVmHe95aX3ct<xR>SZ!mF_;=E9%TT >z!=H2?k#uQ!#csj*X#ia&j=|yCSlf}j<9QU*vf4jT8|B@W63*<5dHt%x+rc=f^*&aN >zE~L}VBbkm%E;`WD_O8q9j-&s`2miFp!jk*&lUn0G?S4DkqO6uOyRDY8k#P_bz&BhG >z7HM^|7+yw%<&CN;zv%Yzwzte_sJltdRIH<8a>lBO^OHl<UtV52v=MqF+xJ6}XK#My >zbG39_@n{(m^LYElqQus*57mE#+$>jkhFaWQr9^IReP0E4vDrj;`uU)|jXYLl&r%L6 >zslDZ7`X3ji^&NDdD3LD|(I_wtrtjSgH<_O@tZCRD&6>;4mMvt8N3MT^)Oj}=8w7g< >zFLp2g8CtOFD>Z!`(K`_Z14k?7NAehdY6~tOB+o}An}$?-W*xA!S$K^k#NaO9^`64t >zU9_PjC!X+{Ip;0BoOo|hNB&ua|JtaT!#(}y;LF=^sXv=)>q1x7ReyWBNg#aqe!(NF >zIcZ;G98;#A*2z3EeYda#ED$9Igw7{we%33j)_)VV(f9XUReH93w806X<%jY9+w)HZ >zx9p>t9oIyG6GZ-l&3$Haj9Ud%jMUEOF<3<9)5|sI0s85f)qt2CXyjx?zKTnu*rBeg >z87^g4LHGU^{=8KsIUes%CQqP_@IE{yb;?%zK&sV=Vr!s;Kyf_g=;J!3ObxY$&Bza& >zTFrm8*#ZFHCofUtPTzU18JOF@lzljEM{z0@044{dCG?vf>Y3!dA}D-Xl;^-Z_4wIB >zzXee2R2?0eo9HpG4oMBQ32Q^01h~@0aHnA}bG@|=#_cLSu{tG%WcgCrYAe4hVyu2o >zpV5$M2h>&|qI3NRg72$uZ12d5kH-6OuhNbjl_+PI%-+<Su33@p0S`xxey1)mUklL- >z{vPv~_4JM?VO9)OBMr8{wyvE!q#w$=v$lCaT^wQ+o4R(K`|IMvZSf?VKrd2=+htDx >z2pwDMwX`_5Vrem8(QmIltTj}PRaYO@K@RJv+X&WR(LKGG+98Ch+7O~2t#Wo`&7}CP >z_AWJeuIt>}fnIY=#b6J-tB(iBb(M+9)DXzz);PRd!`6pPxP(HP1iF(6o&h8j3hU<W >z$z2FS$Fz6>Koigu**g{c9~eX6GANXfr?0mU=_iVO3;;ZuK+fYI8GXAu!!OSN!VbP3 >zB%l9d4d!m|cA@YKYw1hyB!vb29Jpt9;1NWpxd8B61US@H*KF!P&X%@Z{C}3nYGf_4 >zM!lLB5XOUKW^XpX<g)vJaklXd{}=7G0s){j9`&S&@(wO!`wL`;!|dAey)+VwhKleu >z%RdtcbO}QbqYtO3BBQOZEm&Bmfr00$AKY@6Qq2&eUEL=dA_65qN@!+watd`1WJ)kR >ccUG!mJ5qB0l)b@ueXc)%F|{&zXnc|K4@NX-F8}}l > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28993
:
129355
|
129715
|
129981