Bugzilla – Attachment 129720 Details for
Bug 29914
check_cookie_auth not strict enough
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29914: (QA follow-up) Remove warn on timeout
Bug-29914-QA-follow-up-Remove-warn-on-timeout.patch (text/plain), 1.29 KB, created by
Marcel de Rooy
on 2022-01-24 10:36:16 UTC
(
hide
)
Description:
Bug 29914: (QA follow-up) Remove warn on timeout
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-01-24 10:36:16 UTC
Size:
1.29 KB
patch
obsolete
>From 05673cc575e5bf01b6dbdd438e885340485a6f3d Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 21 Jan 2022 10:50:59 +0000 >Subject: [PATCH] Bug 29914: (QA follow-up) Remove warn on timeout >Content-Type: text/plain; charset=utf-8 > >The warn is: >The value of the system preference 'timeout' is not correct, defaulting to 600. > >Caused by previous test. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Auth.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t >index bc5f67fc92..79bf960f43 100755 >--- a/t/db_dependent/Auth.t >+++ b/t/db_dependent/Auth.t >@@ -444,6 +444,8 @@ subtest '_timeout_syspref' => sub { > subtest 'check_cookie_auth' => sub { > plan tests => 1; > >+ t::lib::Mocks::mock_preference('timeout', "1d"); # back to default >+ > my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 1 } }); > > # Mock a CGI object with real userid param >@@ -453,7 +455,6 @@ subtest 'check_cookie_auth' => sub { > sub { > my $var = shift; > if ( $var eq 'userid' ) { return $patron->userid; } >- elsif ( $var eq 'timeout' ) { return 3600; } > } > ); > $cgi->mock('multi_param', sub {return q{}} ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29914
:
129634
|
129643
|
129652
|
129664
|
129682
|
129693
|
129694
|
129718
|
129719
|
129720
|
129725
|
129726
|
129727
|
129728
|
129729
|
129742
|
129743