Attachment 129721 Details for Bug 29931 – Bug 29931: Check cookie status before continuing

[patch] Bug 29931: Check cookie status before continuing

Bug-29931-Check-cookie-status-before-continuing.patch (text/plain), 1.40 KB, created by Jonathan Druart on 2022-01-24 12:52:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-01-24 12:52:05 UTC

Size: 1.40 KB

patch

obsolete

>From 681179960e8c918826d9d80c243a86ab1cf3f23a Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 24 Jan 2022 10:24:08 +0000
>Subject: [PATCH] Bug 29931: Check cookie status before continuing
>
>Test plan:
>Logout from staff.
>Try to run plugins-enable (you should have some active plugin).
>Like: https://yourserver:staffport/cgi-bin/koha/plugins/plugins-enable.pl?class=Koha::Plugin::Test&method=enable
>Replace class and method as appropriate.
>Verify that with this patch, you will be redirected to 401 page.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> plugins/plugins-enable.pl | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/plugins/plugins-enable.pl b/plugins/plugins-enable.pl
>index 146fae96ade..79cd88af880 100755
>--- a/plugins/plugins-enable.pl
>+++ b/plugins/plugins-enable.pl
>@@ -27,8 +27,11 @@ die("Koha plugins are disabled!") unless C4::Context->config("enable_plugins");
> 
> my $input = CGI->new;
> 
>-my ( $auth_status ) =
>-  check_cookie_auth( $input->cookie('CGISESSID'), { plugins => 'manage' } );
>+my ( $auth_status ) = check_cookie_auth( $input->cookie('CGISESSID'), { plugins => 'manage' } );
>+if( $auth_status ne 'ok' ) {
>+    print CGI::header( '-status' => '401' );
>+    exit 0;
>+}
> 
> my $class = $input->param('class');
> my $method = $input->param('method');
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29931: 129717 | 129721 | 129722 | 129746 | 129747 | 129840 | 129841 | 129842 | 129843 | 129844 | 129845 | 131483