Bugzilla – Attachment 129729 Details for
Bug 29914
check_cookie_auth not strict enough
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29914: (QA follow-up) Add comment to explain last case
Bug-29914-QA-follow-up-Add-comment-to-explain-last.patch (text/plain), 834 bytes, created by
Nick Clemens (kidclamp)
on 2022-01-24 14:36:46 UTC
(
hide
)
Description:
Bug 29914: (QA follow-up) Add comment to explain last case
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-01-24 14:36:46 UTC
Size:
834 bytes
patch
obsolete
>From 2758f5b77386276e1d573d0d6e4cc43623984e51 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 24 Jan 2022 14:23:29 +0000 >Subject: [PATCH] Bug 29914: (QA follow-up) Add comment to explain last case > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Auth.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 823cb56c3a..4bf217d094 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1711,6 +1711,8 @@ sub check_cookie_auth { > } else { > return ( "anon", $session ); > } >+ # If here user was logged in, but doesn't have correct permissions >+ # could be an 'else' at 1710, but left here to catch any errors > $session->delete(); > $session->flush; > C4::Context->_unset_userenv($sessionID); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29914
:
129634
|
129643
|
129652
|
129664
|
129682
|
129693
|
129694
|
129718
|
129719
|
129720
|
129725
|
129726
|
129727
|
129728
|
129729
|
129742
|
129743