Attachment 129813 Details for Bug 29946 – Bug 29946: Sort Marc profiles alphabetically

[patch] Bug 29946: Sort Marc profiles alphabetically

Bug-29946-Sort-Marc-profiles-alphabetically.patch (text/plain), 1.48 KB, created by Lucas Gass (lukeg) on 2022-01-25 18:52:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2022-01-25 18:52:00 UTC

Size: 1.48 KB

patch

obsolete

>From e68df1a0220408951b4c39ac330eacac4cc50e65 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 25 Jan 2022 18:46:44 +0000
>Subject: [PATCH] Bug 29946: Sort Marc profiles alphabetically
>
>To test:
>1- Go to Tools > Stage MARC records for import
>2- You'll need a MARC file, choose one and hit 'Upload file'
>3- Create many Profiles with different names. I used ( ATop, ZTop, JTop, STop, etc. )
>4- Notice that the profiles sort in the order in which you create them
>5- Apply patch
>6- Try steps 1-2 again
>7- Now the dropdown should be sorted alphabetically
>8- Make a few more profiles and make sure they are being inserted in the right order alphabetically
>---
> .../intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt   | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
>index 7877265d90..40483ec0d7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
>@@ -482,6 +482,9 @@
>                 .then(resolve, reject);
>             })
>             .then(function(profiles) {
>+                profiles.sort( function(a, b) {
>+                  return a.name < b.name ? -1 :  1;
>+                });
>                 profiles.forEach(function(profile) {
>                     const opt = $("<option/>");
>                     select.append(opt);
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29946: 129813 | 130249 | 132200 | 132240 | 133139