Bugzilla – Attachment 129855 Details for
Bug 20517
Use the "sort bin" field in SIP2 Checkin Response
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20517: (QA follow-up) Fix return undef.
Bug-20517-QA-follow-up-Fix-return-undef.patch (text/plain), 971 bytes, created by
Martin Renvoize (ashimema)
on 2022-01-27 10:02:56 UTC
(
hide
)
Description:
Bug 20517: (QA follow-up) Fix return undef.
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-01-27 10:02:56 UTC
Size:
971 bytes
patch
obsolete
>From 6eae42a67c852cd504929943550c3cb2fbc8d4a1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 27 Jan 2022 09:58:34 +0000 >Subject: [PATCH] Bug 20517: (QA follow-up) Fix return undef. > >--- > C4/SIP/ILS/Transaction/Checkin.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index ee5da78004..9fa73eda0d 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -232,7 +232,7 @@ sub _get_sort_bin { > > # We should get an item represented as a hashref here > my ( $item, $branch ) = @_; >- return undef unless $item; >+ return unless $item; > > # Get the mapping and split on newlines > my $raw_map = C4::Context->preference('SIP2SortBinMapping'); >@@ -275,7 +275,7 @@ sub _get_sort_bin { > } > > # Return undef if no hits were found >- return undef; >+ return; > } > > 1; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20517
:
75126
|
75369
|
103689
|
106291
|
129846
|
129847
|
129848
|
129849
|
129850
|
129851
|
129852
|
129853
|
129854
|
129855
|
132555
|
132556
|
132557
|
132558
|
132559
|
132591
|
132592
|
132593
|
132594
|
132595
|
132596