Bugzilla – Attachment 129882 Details for
Bug 29915
Anonymous session generates 1 new session ID per hit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29915: Add a note for tests
Bug-29915-Add-a-note-for-tests.patch (text/plain), 1.31 KB, created by
Jonathan Druart
on 2022-01-27 14:13:07 UTC
(
hide
)
Description:
Bug 29915: Add a note for tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-01-27 14:13:07 UTC
Size:
1.31 KB
patch
obsolete
>From 528e355be8e1e919756fadf37aeecd9bab7442d0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 27 Jan 2022 15:12:40 +0100 >Subject: [PATCH] Bug 29915: Add a note for tests > >--- > t/db_dependent/Auth.t | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t >index 6e82bd4182f..5228254ab87 100755 >--- a/t/db_dependent/Auth.t >+++ b/t/db_dependent/Auth.t >@@ -602,6 +602,11 @@ subtest 'checkauth & check_cookie_auth' => sub { > ( $auth_status, $session) = C4::Auth::check_cookie_auth( $first_sessionID, { borrowers => 1 } ); > is( $auth_status, 'expired', 'Session no longer exists' ); > >+ # NOTE: It is not what the UI is doing. >+ # From the UI we are allowed to hit an unauthorized page then reuse the session to hit back authorized area. >+ # It is because check_cookie_auth is ALWAYS called from checkauth WITHOUT $flagsrequired >+ # It then return "ok", when the previous called got "failed" >+ > # Try reusing the deleted session: since it does not exist, we should get a new one now when passing correct permissions > $cgi->cookie( -name => 'CGISESSID', value => $first_sessionID ); > ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1}); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29915
:
129644
|
129653
|
129683
|
129748
|
129750
|
129751
|
129752
|
129753
|
129754
|
129755
|
129756
|
129822
|
129826
|
129827
|
129828
|
129829
|
129830
|
129831
|
129832
|
129833
|
129860
|
129861
|
129862
|
129863
|
129864
|
129865
|
129866
|
129878
|
129879
|
129880
|
129882
|
129883
|
129884
|
129885
|
129886
|
129887
|
129888
|
129889
|
129906
|
129907
|
129908
|
129909
|
129910
|
129911
|
129912
|
129913
|
129951
|
130596
|
130597
|
130598
|
130599
|
130600
|
130601
|
130602
|
130603
|
130604
|
131708
|
131709
|
131710
|
131711
|
131712
|
131713
|
131714
|
131715
|
131716
|
131788
|
131789
|
131790
|
131791
|
131792
|
131793
|
131794
|
131795
|
131796
|
131797
|
132101
|
132104
|
132114
|
132158
|
132159